All of lore.kernel.org
 help / color / mirror / Atom feed
From: vadim4j@gmail.com
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next] Allow to set net namespace for wireless device via RTM_LINK
Date: Tue, 14 Oct 2014 15:16:27 +0300	[thread overview]
Message-ID: <20141014121627.GA5115@angus-think.lan> (raw)
In-Reply-To: <1411075535.2034.5.camel@jlt4.sipsolutions.net>

On Thu, Sep 18, 2014 at 11:25:35PM +0200, Johannes Berg wrote:
> On Thu, 2014-09-11 at 23:35 +0300, Vadim Kochan wrote:
> > Added new netdev_ops callback for setting namespace in specific
> > for this device way
> 
> > +++ b/include/linux/netdevice.h
> > @@ -997,6 +997,8 @@ typedef u16 (*select_queue_fallback_t)(struct net_device *dev,
> >   *	Callback to use for xmit over the accelerated station. This
> >   *	is used in place of ndo_start_xmit on accelerated net
> >   *	devices.
> > + * int (*ndo_set_netns)(struct net_device *dev, struct net *net);
> > + *      Callback to set net namespace in specific way for this device.
> 
> For the record, I don't consider it appropriate to set the net namespace
> on one netdev and end up with multiple netdevs switching namespaces ...
> 
> As a result, I don't think this should done.
> 
> johannes
> 

The reason for this was to make possible to change netns for wireless
dev via 'ip link' too like for 'iw' util. I just think that changing
namespace for netdev should have the generic way. May be you can suggest
a better way

Thanks,

  reply	other threads:[~2014-10-14 12:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11 20:35 [PATCH net-next] Allow to set net namespace for wireless device via RTM_LINK Vadim Kochan
2014-09-18 21:25 ` Johannes Berg
2014-09-18 21:25   ` Johannes Berg
2014-10-14 12:16   ` vadim4j [this message]
2014-10-20  9:47     ` Johannes Berg
2014-10-20  9:47       ` Johannes Berg
2014-10-20 10:46       ` Marcel Holtmann
2014-10-20 10:46         ` Marcel Holtmann
2014-10-20 10:52         ` Johannes Berg
2014-10-20 10:52           ` Johannes Berg
2014-12-24  9:48           ` Vadim Kochan
2015-01-05  9:22             ` Johannes Berg
2015-01-05  9:22               ` Johannes Berg
2015-01-12  9:07               ` Vadim Kochan
2015-01-12  9:42                 ` Johannes Berg
2015-01-12  9:57                   ` Vadim Kochan
2015-01-12  9:58                     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141014121627.GA5115@angus-think.lan \
    --to=vadim4j@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.