From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/5] infra: Add automatic install of init scripts
Date: Sat, 18 Oct 2014 18:56:01 +0200 [thread overview]
Message-ID: <20141018185601.1a8e732c@free-electrons.com> (raw)
In-Reply-To: <1413643624-14757-4-git-send-email-maxime.hadjinlian@gmail.com>
Dear Maxime Hadjinlian,
On Sat, 18 Oct 2014 16:47:02 +0200, Maxime Hadjinlian wrote:
> +ifeq ($(BR2_INIT_SYSTEMD),y)
> + $(Q)if test -n "$($(PKG)_INIT_SYSTEMD_FILES)" ; then \
> + mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants ; \
> + for s in $($(PKG)_INIT_SYSTEMD_FILES); do \
> + f=$$(basename $${s}); \
> + $(INSTALL) -D -m 644 $${s} $(TARGET_DIR)/lib/systemd/system/$${f} ; \
> + ln -fs /lib/systemd/system/$${f} \
> + $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/$${f} ; \
> + done ; \
> + fi
> + $($(PKG)_INSTALL_INIT_SYSTEMD)
> +endif
> +ifeq ($(BR2_INIT_SYSV)$(BR2_INIT_BUSYBOX),y)
> + $(Q)if test -n "$($(PKG)_INIT_SYSV_FILES)" ; then \
> + for s in $($(PKG)_INIT_SYSV_FILES); do \
> + f=$$(basename $${s}) ; \
> + $(INSTALL) -D -m 0755 $${s} $(TARGET_DIR)/etc/init.d/$${f} ; \
> + done ; \
> + fi
> + $($(PKG)_INSTALL_INIT_SYSV)
> +endif
Why is an explicit variable necessary ? Why not simply install all the
S* and K* files from the package directory for sysvinit/busybox and all
the .service (or some extension) of the package directory for systemd ?
I think we discussed this at the meeting, no?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-18 16:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-18 14:46 [Buildroot] [PATCH 0/5] Various init scripts modification Maxime Hadjinlian
2014-10-18 14:47 ` [Buildroot] [PATCH 1/5] initscripts: new package Maxime Hadjinlian
2015-02-03 10:32 ` Thomas Petazzoni
2014-10-18 14:47 ` [Buildroot] [PATCH 2/5] busybox: Install scripts only when needed Maxime Hadjinlian
2014-10-18 16:53 ` Thomas Petazzoni
2014-10-18 16:54 ` Maxime Hadjinlian
2015-02-03 10:31 ` Thomas Petazzoni
2014-10-18 14:47 ` [Buildroot] [PATCH 3/5] infra: Add automatic install of init scripts Maxime Hadjinlian
2014-10-18 16:56 ` Thomas Petazzoni [this message]
2014-10-18 16:59 ` Maxime Hadjinlian
2014-10-18 17:06 ` Thomas Petazzoni
2014-10-18 17:11 ` Maxime Hadjinlian
2014-10-18 17:23 ` Thomas Petazzoni
2014-10-18 17:02 ` Thomas Petazzoni
2014-10-18 18:52 ` André Erdmann
2014-10-18 14:47 ` [Buildroot] [PATCH 4/5] acpid: Use new FOO_INIT_SYSV_FILES variable Maxime Hadjinlian
2014-10-18 14:47 ` [Buildroot] [PATCH 5/5] am33x-cm3: " Maxime Hadjinlian
2015-02-03 10:29 ` [Buildroot] [PATCH 0/5] Various init scripts modification Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141018185601.1a8e732c@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.