From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com, cluster-devel@redhat.com,
Steven Whitehouse <swhiteho@redhat.com>,
Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>,
ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org,
Jeff Mahoney <jeffm@suse.de>, Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, tytso@mit.edu,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode
Date: Sat, 18 Oct 2014 21:26:24 +0200 [thread overview]
Message-ID: <20141018192624.GA16478@quack.suse.cz> (raw)
In-Reply-To: <20141018151738.GG30355@infradead.org>
On Sat 18-10-14 08:17:38, Christoph Hellwig wrote:
> On Fri, Oct 17, 2014 at 09:24:28PM +0200, Jan Kara wrote:
> > I don't see the 4-bytes per inode saving, what am I missing? Frankly, I
> > don't see a difference in readability but since you and Al agree on that I
> > concede to your taste :)
>
> It's the removal of s_inode_fields that saves 4 bytes.
But that was in the superblock, not in the inode...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, Jan Kara <jack@suse.cz>,
Jeff Mahoney <jeffm@suse.de>, Mark Fasheh <mfasheh@suse.com>,
reiserfs-devel@vger.kernel.org, xfs@oss.sgi.com,
cluster-devel@redhat.com, Joel Becker <jlbec@evilplan.org>,
linux-fsdevel@vger.kernel.org, tytso@mit.edu,
linux-ext4@vger.kernel.org,
Steven Whitehouse <swhiteho@redhat.com>,
ocfs2-devel@oss.oracle.com, viro@zeniv.linux.org.uk
Subject: Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode
Date: Sat, 18 Oct 2014 21:26:24 +0200 [thread overview]
Message-ID: <20141018192624.GA16478@quack.suse.cz> (raw)
In-Reply-To: <20141018151738.GG30355@infradead.org>
On Sat 18-10-14 08:17:38, Christoph Hellwig wrote:
> On Fri, Oct 17, 2014 at 09:24:28PM +0200, Jan Kara wrote:
> > I don't see the 4-bytes per inode saving, what am I missing? Frankly, I
> > don't see a difference in readability but since you and Al agree on that I
> > concede to your taste :)
>
> It's the removal of s_inode_fields that saves 4 bytes.
But that was in the superblock, not in the inode...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com, cluster-devel@redhat.com,
Steven Whitehouse <swhiteho@redhat.com>,
Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>,
ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org,
Jeff Mahoney <jeffm@suse.de>, Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, tytso@mit.edu,
viro@zeniv.linux.org.uk
Subject: [Ocfs2-devel] [PATCH 0/12 v2] Moving i_dquot out of struct inode
Date: Sat, 18 Oct 2014 21:26:24 +0200 [thread overview]
Message-ID: <20141018192624.GA16478@quack.suse.cz> (raw)
In-Reply-To: <20141018151738.GG30355@infradead.org>
On Sat 18-10-14 08:17:38, Christoph Hellwig wrote:
> On Fri, Oct 17, 2014 at 09:24:28PM +0200, Jan Kara wrote:
> > I don't see the 4-bytes per inode saving, what am I missing? Frankly, I
> > don't see a difference in readability but since you and Al agree on that I
> > concede to your taste :)
>
> It's the removal of s_inode_fields that saves 4 bytes.
But that was in the superblock, not in the inode...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 0/12 v2] Moving i_dquot out of struct inode
Date: Sat, 18 Oct 2014 21:26:24 +0200 [thread overview]
Message-ID: <20141018192624.GA16478@quack.suse.cz> (raw)
In-Reply-To: <20141018151738.GG30355@infradead.org>
On Sat 18-10-14 08:17:38, Christoph Hellwig wrote:
> On Fri, Oct 17, 2014 at 09:24:28PM +0200, Jan Kara wrote:
> > I don't see the 4-bytes per inode saving, what am I missing? Frankly, I
> > don't see a difference in readability but since you and Al agree on that I
> > concede to your taste :)
>
> It's the removal of s_inode_fields that saves 4 bytes.
But that was in the superblock, not in the inode...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2014-10-18 19:26 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 14:54 [PATCH 0/12 v2] Moving i_dquot out of struct inode Jan Kara
2014-10-10 14:54 ` [Cluster-devel] " Jan Kara
2014-10-10 14:54 ` [Ocfs2-devel] " Jan Kara
2014-10-10 14:54 ` Jan Kara
2014-10-10 14:54 ` [PATCH 01/12] quota: Allow each filesystem to specify which quota types it supports Jan Kara
2014-10-10 14:54 ` [Cluster-devel] " Jan Kara
2014-10-10 14:54 ` [Ocfs2-devel] " Jan Kara
2014-10-10 14:54 ` Jan Kara
2014-10-10 15:26 ` Dave Kleikamp
2014-10-10 15:26 ` [Cluster-devel] " Dave Kleikamp
2014-10-10 15:26 ` [Ocfs2-devel] " Dave Kleikamp
2014-10-10 15:26 ` Dave Kleikamp
2014-10-10 15:37 ` Jan Kara
2014-10-10 15:37 ` [Cluster-devel] " Jan Kara
2014-10-10 15:37 ` [Ocfs2-devel] " Jan Kara
2014-10-10 15:37 ` Jan Kara
2014-10-10 14:55 ` [PATCH 02/12] gfs2: Set allowed quota types Jan Kara
2014-10-10 14:55 ` [Cluster-devel] " Jan Kara
2014-10-10 14:55 ` [Ocfs2-devel] " Jan Kara
2014-10-10 14:55 ` Jan Kara
2014-10-10 14:55 ` [PATCH 03/12] xfs: " Jan Kara
2014-10-10 14:55 ` [Cluster-devel] " Jan Kara
2014-10-10 14:55 ` [Ocfs2-devel] " Jan Kara
2014-10-10 14:55 ` Jan Kara
2014-10-10 14:55 ` [PATCH 04/12] fs: Generic infrastructure for optional inode fields Jan Kara
2014-10-10 14:55 ` [Cluster-devel] " Jan Kara
2014-10-10 14:55 ` [Ocfs2-devel] " Jan Kara
2014-10-10 14:55 ` Jan Kara
2014-10-10 14:55 ` [PATCH 05/12] quota: Use optional inode field for i_dquot pointers Jan Kara
2014-10-10 14:55 ` [Cluster-devel] " Jan Kara
2014-10-10 14:55 ` [Ocfs2-devel] " Jan Kara
2014-10-10 14:55 ` Jan Kara
2014-10-10 14:55 ` [PATCH 06/12] ext2: Convert to private i_dquot field Jan Kara
2014-10-10 14:55 ` [Cluster-devel] " Jan Kara
2014-10-10 14:55 ` [Ocfs2-devel] " Jan Kara
2014-10-10 14:55 ` Jan Kara
2014-10-10 14:55 ` [PATCH 07/12] ext3: " Jan Kara
2014-10-10 14:55 ` [Cluster-devel] " Jan Kara
2014-10-10 14:55 ` [Ocfs2-devel] " Jan Kara
2014-10-10 14:55 ` [PATCH 08/12] ext4: " Jan Kara
2014-10-10 14:55 ` [Cluster-devel] " Jan Kara
2014-10-10 14:55 ` [Ocfs2-devel] " Jan Kara
2014-10-10 14:55 ` Jan Kara
2014-10-10 14:55 ` [PATCH 09/12] ocfs2: " Jan Kara
2014-10-10 14:55 ` [Cluster-devel] " Jan Kara
2014-10-10 14:55 ` [Ocfs2-devel] " Jan Kara
2014-10-10 14:55 ` Jan Kara
2014-10-10 14:55 ` [PATCH 10/12] reiserfs: " Jan Kara
2014-10-10 14:55 ` [Cluster-devel] " Jan Kara
2014-10-10 14:55 ` [Ocfs2-devel] " Jan Kara
2014-10-10 14:55 ` Jan Kara
2014-10-10 14:55 ` [PATCH 11/12] jfs: " Jan Kara
2014-10-10 14:55 ` [Cluster-devel] " Jan Kara
2014-10-10 14:55 ` [Ocfs2-devel] " Jan Kara
2014-10-10 14:55 ` Jan Kara
2014-10-10 15:33 ` Dave Kleikamp
2014-10-10 15:33 ` [Cluster-devel] " Dave Kleikamp
2014-10-10 15:33 ` [Ocfs2-devel] " Dave Kleikamp
2014-10-10 15:33 ` Dave Kleikamp
2014-10-10 15:40 ` Jan Kara
2014-10-10 15:40 ` [Cluster-devel] " Jan Kara
2014-10-10 15:40 ` [Ocfs2-devel] " Jan Kara
2014-10-10 15:40 ` Jan Kara
2014-10-10 15:43 ` Dave Kleikamp
2014-10-10 15:43 ` [Cluster-devel] " Dave Kleikamp
2014-10-10 15:43 ` [Ocfs2-devel] " Dave Kleikamp
2014-10-10 15:43 ` Dave Kleikamp
2014-10-10 14:55 ` [PATCH 12/12] vfs: Remove i_dquot field from inode Jan Kara
2014-10-10 14:55 ` [Cluster-devel] " Jan Kara
2014-10-10 14:55 ` [Ocfs2-devel] " Jan Kara
2014-10-10 14:55 ` Jan Kara
2014-10-11 13:34 ` [PATCH 0/12 v2] Moving i_dquot out of struct inode Christoph Hellwig
2014-10-11 13:34 ` [Cluster-devel] " Christoph Hellwig
2014-10-11 13:34 ` [Ocfs2-devel] " Christoph Hellwig
2014-10-11 13:34 ` Christoph Hellwig
2014-10-12 18:53 ` Al Viro
2014-10-12 18:53 ` [Cluster-devel] " Al Viro
2014-10-12 18:53 ` [Ocfs2-devel] " Al Viro
2014-10-12 18:53 ` Al Viro
2014-10-17 19:24 ` Jan Kara
2014-10-17 19:24 ` [Cluster-devel] " Jan Kara
2014-10-17 19:24 ` [Ocfs2-devel] " Jan Kara
2014-10-17 19:24 ` Jan Kara
2014-10-18 15:17 ` Christoph Hellwig
2014-10-18 15:17 ` [Cluster-devel] " Christoph Hellwig
2014-10-18 15:17 ` [Ocfs2-devel] " Christoph Hellwig
2014-10-18 15:17 ` Christoph Hellwig
2014-10-18 19:26 ` Jan Kara [this message]
2014-10-18 19:26 ` [Cluster-devel] " Jan Kara
2014-10-18 19:26 ` [Ocfs2-devel] " Jan Kara
2014-10-18 19:26 ` Jan Kara
2014-10-19 14:16 ` Christoph Hellwig
2014-10-19 14:16 ` [Cluster-devel] " Christoph Hellwig
2014-10-19 14:16 ` [Ocfs2-devel] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141018192624.GA16478@quack.suse.cz \
--to=jack@suse.cz \
--cc=cluster-devel@redhat.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jeffm@suse.de \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jlbec@evilplan.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=shaggy@kernel.org \
--cc=swhiteho@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.