From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from e06smtp12.uk.ibm.com ([195.75.94.108]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XgXjM-0006pY-31 for kexec@lists.infradead.org; Tue, 21 Oct 2014 11:36:01 +0000 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 21 Oct 2014 12:35:37 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 5AF5417D804E for ; Tue, 21 Oct 2014 12:35:34 +0100 (BST) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s9LBZYTH54198436 for ; Tue, 21 Oct 2014 11:35:34 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s9LBZYPE012820 for ; Tue, 21 Oct 2014 05:35:34 -0600 Date: Tue, 21 Oct 2014 13:35:33 +0200 From: Michael Holzheu Subject: Re: makedumpfile-1.5.7: Compile warnings on archs without get_versiondep_info() Message-ID: <20141021133533.039f3243@holzheu> In-Reply-To: <0910DD04CBD6DE4193FCF86B9C00BE9701D57383@BPXM01GP.gisp.nec.co.jp> References: <20140926101619.56f90824@holzheu> <0910DD04CBD6DE4193FCF86B9C00BE9701D57383@BPXM01GP.gisp.nec.co.jp> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Atsushi Kumagai Cc: "kexec@lists.infradead.org" On Tue, 21 Oct 2014 05:13:37 +0000 Atsushi Kumagai wrote: > Hello Michael, > > >I just noticed that makedumpfile-1.5.7 produces warnings > >on s390x and probably all other archs that have not defined > >get_versiondep_info(): > > Thanks for your reporting, does this patch help you ? Hello Atsushi, Sorry, the first note was sent by accident... I had problems applying the patch but after manually adding the changes I still get the following warning: elf_info.c: In function 'get_kcore_dump_loads': elf_info.c:855:27: warning: unused variable 'p' [-Wunused-variable] struct pt_load_segment *p = &pt_loads[i]; What about the following patch: --- makedumpfile.h | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) --- a/makedumpfile.h +++ b/makedumpfile.h @@ -759,26 +759,28 @@ do { \ /* * The function of dependence on machine */ +static inline int stub_true() { return TRUE; } +static inline int stub_true_ul(unsigned long x) { return TRUE; } #ifdef __arm__ int get_phys_base_arm(void); int get_machdep_info_arm(void); unsigned long long vaddr_to_paddr_arm(unsigned long vaddr); #define get_phys_base() get_phys_base_arm() #define get_machdep_info() get_machdep_info_arm() -#define get_versiondep_info() TRUE +#define get_versiondep_info() stub_true() #define vaddr_to_paddr(X) vaddr_to_paddr_arm(X) -#define is_vmalloc_addr(X) TRUE +#define is_vmalloc_addr(X) stub_true_ul(X) #endif /* arm */ #ifdef __x86__ int get_machdep_info_x86(void); int get_versiondep_info_x86(void); unsigned long long vaddr_to_paddr_x86(unsigned long vaddr); -#define get_phys_base() TRUE +#define get_phys_base() stub_true() #define get_machdep_info() get_machdep_info_x86() #define get_versiondep_info() get_versiondep_info_x86() #define vaddr_to_paddr(X) vaddr_to_paddr_x86(X) -#define is_vmalloc_addr(X) TRUE +#define is_vmalloc_addr(X) stub_true_ul(X) #endif /* x86 */ #ifdef __x86_64__ @@ -798,31 +800,31 @@ unsigned long long vaddr_to_paddr_x86_64 int get_machdep_info_ppc64(void); int get_versiondep_info_ppc64(void); unsigned long long vaddr_to_paddr_ppc64(unsigned long vaddr); -#define get_phys_base() TRUE +#define get_phys_base() stub_true() #define get_machdep_info() get_machdep_info_ppc64() #define get_versiondep_info() get_versiondep_info_ppc64() #define vaddr_to_paddr(X) vaddr_to_paddr_ppc64(X) -#define is_vmalloc_addr(X) TRUE +#define is_vmalloc_addr(X) stub_true_ul(X) #endif /* powerpc64 */ #ifdef __powerpc32__ /* powerpc32 */ int get_machdep_info_ppc(void); unsigned long long vaddr_to_paddr_ppc(unsigned long vaddr); -#define get_phys_base() TRUE +#define get_phys_base() stub_true() #define get_machdep_info() get_machdep_info_ppc() -#define get_versiondep_info() TRUE +#define get_versiondep_info() stub_true() #define vaddr_to_paddr(X) vaddr_to_paddr_ppc(X) -#define is_vmalloc_addr(X) TRUE +#define is_vmalloc_addr(X) stub_true_ul(X) #endif /* powerpc32 */ #ifdef __s390x__ /* s390x */ int get_machdep_info_s390x(void); unsigned long long vaddr_to_paddr_s390x(unsigned long vaddr); -#define get_phys_base() TRUE +#define get_phys_base() stub_true() #define get_machdep_info() get_machdep_info_s390x() -#define get_versiondep_info() TRUE +#define get_versiondep_info() stub_true() #define vaddr_to_paddr(X) vaddr_to_paddr_s390x(X) -#define is_vmalloc_addr(X) TRUE +#define is_vmalloc_addr(X) stub_true_ul(X) #endif /* s390x */ #ifdef __ia64__ /* ia64 */ @@ -831,10 +833,10 @@ int get_machdep_info_ia64(void); unsigned long long vaddr_to_paddr_ia64(unsigned long vaddr); #define get_machdep_info() get_machdep_info_ia64() #define get_phys_base() get_phys_base_ia64() -#define get_versiondep_info() TRUE +#define get_versiondep_info() stub_true() #define vaddr_to_paddr(X) vaddr_to_paddr_ia64(X) #define VADDR_REGION(X) (((unsigned long)(X)) >> REGION_SHIFT) -#define is_vmalloc_addr(X) TRUE +#define is_vmalloc_addr(X) stub_true_ul(X) #endif /* ia64 */ typedef unsigned long long mdf_pfn_t; _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec