From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] coreutils: fix libintl, reorder ENV, OPTS & PROGS
Date: Sun, 26 Oct 2014 13:58:39 +0100 [thread overview]
Message-ID: <20141026135839.71d17069@free-electrons.com> (raw)
In-Reply-To: <1414326790-26103-1-git-send-email-gustavo@zacarias.com.ar>
Dear Gustavo Zacarias,
On Sun, 26 Oct 2014 09:33:10 -0300, Gustavo Zacarias wrote:
> Move OPTS, ENV & PROGS up to the top, the fact that a conditional
> (BR2_PACKAGE_BUSYBOX) was before them is bad style and confused me while
> i tried to get them grouped together.
> This was making all of the new disable OPTS fail, pretty much harmless
> but still.
>
> Account for libintl/gettext presence, it's not required in any toolchain
> combination but it will fail if it's present, so use it when it's
> selected by some other package. Fixes:
> http://autobuild.buildroot.net/results/30d/30d0e3d27d8606443479466e60716e6f202a4711/
>
> Add conditional on OpenSSL for faster hashing binaries as pointed again
> by P?draig Brady.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> package/coreutils/coreutils.mk | 94 +++++++++++++++++++++++-------------------
> 1 file changed, 52 insertions(+), 42 deletions(-)
Applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-10-26 12:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 12:33 [Buildroot] [PATCH] coreutils: fix libintl, reorder ENV, OPTS & PROGS Gustavo Zacarias
2014-10-26 12:58 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141026135839.71d17069@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.