All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] ejabberd: new package
Date: Mon, 27 Oct 2014 15:47:00 +0100	[thread overview]
Message-ID: <20141027154700.29de541e@free-electrons.com> (raw)
In-Reply-To: <CAJtjsKbaAKyGODDjpcCQRnzP__weqk1Jt8fTWnWVVMt7KPJM_Q@mail.gmail.com>

Dear Johan Oudinet,

On Mon, 27 Oct 2014 15:42:48 +0100, Johan Oudinet wrote:

> I (with the help of a colleague) manage to package every ejabberd
> dependency separately. We also had to package rebar because some
> erlang packages rely on it but do not provide it. Therefore, if an
> erlang package includes a rebar script, we use it. Otherwise, we add a
> dependency on host-erlang-rebar and we use this one instead.
> To simplify the task (12 erlang packages), we created a pkg-rebar.mk
> file that provides {host-}rebar-package, similar to pkg-autotools.mk.
> In doing so, we had to factorize the hooks in pkg-autotools.mk.
> 
> I guess the minor modifications of pkg-autotools.mk should be pushed
> in a separate patch.
> Then, should I push the rest of my commits as a big new revision of
> this patch, or should I push each erlang package as a separate patch ?

Each should be a separate patch. Basically, you should send a patch
series, which contains separate patches for the various functionalities
(new package infrastructure, changes to existing package
infrastructure, new packages, etc.). Do not forget to document what you
are doing in the commit logs, especially for the modification to
existing package infrastructures and the new package infra.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2014-10-27 14:47 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18 12:33 [Buildroot] [PATCH v3] ejabberd: new package Johan Oudinet
2014-07-18 21:35 ` Yann E. MORIN
2014-07-18 23:58   ` Johan Oudinet
2014-07-19  9:17     ` Yann E. MORIN
2014-07-20  9:33 ` Thomas Petazzoni
2014-08-06 10:30   ` Johan Oudinet
2014-08-06 19:40     ` Yann E. MORIN
2014-08-06 20:23 ` Yann E. MORIN
2014-08-11  9:36   ` Johan Oudinet
2014-08-11 10:07     ` Johan Oudinet
2014-08-11 10:13       ` Yann E. MORIN
2014-08-11 10:33     ` Yann E. MORIN
2014-08-11 10:50       ` Yann E. MORIN
2014-08-13 18:48         ` Frank Hunleth
2014-08-13 19:51           ` Yann E. MORIN
2014-08-13 20:44           ` Yann E. MORIN
2014-08-13 21:23             ` Frank Hunleth
2014-08-13 21:49               ` Yann E. MORIN
2014-08-13 22:18                 ` Yann E. MORIN
2014-08-14 12:40                   ` Frank Hunleth
2014-08-14 22:36                     ` Yann E. MORIN
2014-08-11 13:13       ` Johan Oudinet
2014-08-12 15:13         ` Yann E. MORIN
2014-10-11 16:21 ` Yann E. MORIN
2014-10-16 12:38   ` Johan Oudinet
2014-10-17 20:18     ` Yann E. MORIN
2014-10-17 23:06     ` Arnout Vandecappelle
2014-10-18 10:00       ` Yann E. MORIN
2014-10-18 10:31         ` Johan Oudinet
2014-10-27 14:42           ` Johan Oudinet
2014-10-27 14:47             ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141027154700.29de541e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.