From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl8Ty-0002R1-LD for qemu-devel@nongnu.org; Sun, 02 Nov 2014 22:39:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xl8Tr-0007NL-Sm for qemu-devel@nongnu.org; Sun, 02 Nov 2014 22:39:06 -0500 Received: from ozlabs.org ([103.22.144.67]:55281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl8Tr-0007Mh-He for qemu-devel@nongnu.org; Sun, 02 Nov 2014 22:38:59 -0500 Date: Mon, 3 Nov 2014 14:20:33 +1100 From: David Gibson Message-ID: <20141103032033.GJ8949@voom.redhat.com> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-15-git-send-email-dgilbert@redhat.com> <5430378A.5030604@redhat.com> <20141023162331.GA21829@work-vm> <544961D8.5040203@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OX7PPUk8qMPP4++R" Content-Disposition: inline In-Reply-To: <544961D8.5040203@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 14/47] Return path: Control commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com --OX7PPUk8qMPP4++R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 23, 2014 at 10:15:20PM +0200, Paolo Bonzini wrote: >=20 >=20 > On 10/23/2014 06:23 PM, Dr. David Alan Gilbert wrote: > > * Paolo Bonzini (pbonzini@redhat.com) wrote: > >> Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > >>> QEMU_VM_CMD_INVALID =3D 0, /* Must be 0 */ > >>> + QEMU_VM_CMD_OPENRP, /* Tell the dest to open the Return p= ath */ > >> > >> OPEN_RETURN_PATH? > >> > >>> + QEMU_VM_CMD_REQACK, /* Request an ACK on the RP */ > >> > >> SEND_ACK or ACK_REQUESTED? > >> > >>> QEMU_VM_CMD_AFTERLASTVALID > >> > >> Pleaseseparatewords. Is this enum actually used at all? > >> > >> Please avoid the difference between QEMU_VM_CMD and MIG_RPCOMM_. > >> > >> Perhaps MIG_CMD and MIG_RPCMD_? > >=20 > > Almost, I went with: > >=20 > > MIG_CMD_INVALID =3D 0, /* Must be 0 */ > > MIG_CMD_OPEN_RETURN_PATH, /* Tell the dest to open the Return path= */ > > MIG_CMD_SEND_ACK, /* Request an ACK on the RP */ > > MIG_CMD_PACKAGED, /* Send a wrapped stream within this str= eam */ > >=20 > > MIG_CMD_POSTCOPY_ADVISE =3D 20, /* Prior to any page transfers, ju= st > > warn we might want to do PC */ > > MIG_CMD_POSTCOPY_LISTEN, /* Start listening for incoming > > pages as it's running. */ > > MIG_CMD_POSTCOPY_RUN, /* Start execution */ > > MIG_CMD_POSTCOPY_END, /* Postcopy is finished. */ > >=20 > > MIG_CMD_POSTCOPY_RAM_DISCARD, /* A list of pages to discard that > > were previously sent during > > precopy but are dirty. */ > >=20 > > and > > MIG_RP_CMD_INVALID =3D 0, /* Must be 0 */ > > MIG_RP_CMD_SHUT, /* sibling will not send any more RP messa= ges */ > > MIG_RP_CMD_ACK, /* data (seq: be32 ) */ > > MIG_RP_CMD_REQ_PAGES, /* data (start: be64, len: be64) */ > >=20 > > the only oddity I get from that is from the 'SEND_ACK' you suggested; > > since all my functions to send commands are send_ I currently have > > 'qemu_savevm_send_send_ack' which while consistent looks a bit odd. >=20 > Perhaps ping/pong? I like that idea. Calling it "send_ack" looks like it's just asking for confusing names somewhere. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --OX7PPUk8qMPP4++R Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUVvSBAAoJEGw4ysog2bOS398QAJROQoBSjo/x2Ouwl35E0bnu TC6IzhbF5r6vM4YbMSKR7NHIFDy6ZDMo1G0+e4WIiQrA/dCnfNwkgXUb1rn5TseS XBM54ERxBm6soA+KjXO7zbmWPTpev5dHn+0r5vXSDh3LlS4mlxnroo3OW+ykkfNt Z8m981KY0Sou53+6fRcZNXLaZI/sHRiHj5JQ2M0BR/vseJsiZrb/F060Li/eNJwt JDdmoKowILQj4buOHy5uMP6bteS1sy6kClYLbThR3BTyc37q6S+6IjGdoHU3v6Fs 1fs3ZS4KHNmJh8L0kjz5yj2GzSWarU28d5ZiTXMLWb6UoiZVi004dnyOHaPZuxn4 tte1uYFHU57+8/V4PGzC6TDVd0EmxVxDpbI20ToxWzfvprR7pUzuTi6SoxCDV6Jq BrREIE2Y72Hx3nk80Z6JO57baLxupoaPmXUHt2ScPUF2C+Lvds0IT5MJePv0Rv6o tDMzpCYB7QbVziXUe6SZEMe5fEPpF0bFgu8cJ40FIWB58PoX21Pi5aVNXW6UnxnJ s8U2prgcRXMqGjpIDHIcAcMjrPjs7NEhT1+zUMeP9AMn1L3liZZbE+4TACVEVHrc IYvtQw/e+cwoW4pk71KtyYWeEPfDsX7VGiw10IebBAhridrg4eIedNb2W/hVzA3P gsm5k9X3yUlJzciLFj4o =Bgbk -----END PGP SIGNATURE----- --OX7PPUk8qMPP4++R--