From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlA5h-0004Zl-PD for qemu-devel@nongnu.org; Mon, 03 Nov 2014 00:22:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlA5f-0005K0-Az for qemu-devel@nongnu.org; Mon, 03 Nov 2014 00:22:09 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:37280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlA5e-0005GG-Vv for qemu-devel@nongnu.org; Mon, 03 Nov 2014 00:22:07 -0500 Date: Mon, 3 Nov 2014 16:08:19 +1100 From: David Gibson Message-ID: <20141103050819.GP8949@voom.redhat.com> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-20-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3bc47Eih9dS+biPM" Content-Disposition: inline In-Reply-To: <1412358473-31398-20-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com --3bc47Eih9dS+biPM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 03, 2014 at 06:47:25PM +0100, Dr. David Alan Gilbert (git) wrot= e: > From: "Dr. David Alan Gilbert" >=20 > Postcopy needs to have two migration streams loading concurrently; > one from memory (with the device state) and the other from the fd > with the memory transactions. >=20 > Split the core of qemu_loadvm_state out so we can use it for both. >=20 > Allow the inner loadvm loop to quit and signal whether the parent > should. >=20 > loadvm_handlers is made static since it's lifetime is greater > than the outer qemu_loadvm_state. Maybe it's just me, but "made static" to me indicates either a change =66rom fully-global to module-global, or (function) local automatic to local static, not a change from function local-automatic to module-global as here. It's also not clear from this patch alone why the lifetime of loadvm_handlers now needs to exceed that of qemu_loadvm_state(). --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --3bc47Eih9dS+biPM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUVw3DAAoJEGw4ysog2bOS8EQQALDFXoIACxOcSmnzU0zhhPde ZIDgYHmHFd7Mto5aigxFqcMvulO2BVUCUfBo9z4ksUvJw9GZ/kfLQzEyCw5MhZJs +NONvKnnC3WU658006ULMnHqNjXbAGqGZSeafLUMjO549g3rIciA2eBWO74GC89f wFICJVsiVHDcZGsyjNlgtDHepVO5bGkJYUXOW0w87P4AcgyteDOyffsbaTnaHRq5 ik3LBEgv/3W31SGX1dtuiU69Cih5rr38w72T4tjLiA/2KK1fut31Iay3Z1C+EhRL ThLYzayV6Bdys7vA9WczLZaHTxRs5fcyOyC4xY35CIDS9kIUgFkz9nyNuJeAs1ER rZFXR1fGz00oO7LL9M4Upnl+WVInimXkGeALmjlEkNkZdAK5jrMBgoHDeO+OFbVr jaU8vvgAGdGXl+4djCVth/yQW0tF8rJXNRvX/lXqbVs9UkWHWp/+hIAVEW1Ih683 jZHVb1pdoh8/UJmr4xXZCLZiGDafCC1zltAWWwAkQgNVrpRGQq13T4Hjo32k8WmM uVsGp7WD0eIG3KJ4n94DNGgvXwHgRb4vhvWGIIO+5gVW1NH9C46cwL+TGy1rUzyC euRZMSQiarJPy6wrs6OCoNzUbK+3qV1/5XszXnlPE0KCxpdhsvLw88wqQlxsmPN+ 8vrnk09dN3E/PxQGa4GJ =hSAl -----END PGP SIGNATURE----- --3bc47Eih9dS+biPM--