From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753781AbaKDN5e (ORCPT ); Tue, 4 Nov 2014 08:57:34 -0500 Received: from mail-qc0-f181.google.com ([209.85.216.181]:57657 "EHLO mail-qc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbaKDN5a (ORCPT ); Tue, 4 Nov 2014 08:57:30 -0500 Date: Tue, 4 Nov 2014 08:57:26 -0500 From: Tejun Heo To: Aditya Kali Cc: Andy Lutomirski , Li Zefan , Serge Hallyn , "Eric W. Biederman" , cgroups@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux API , Ingo Molnar , Linux Containers , Rohit Jnagal Subject: Re: [PATCHv2 7/7] cgroup: mount cgroupns-root when inside non-init cgroupns Message-ID: <20141104135726.GB14014@htj.dyndns.org> References: <1414783141-6947-1-git-send-email-adityakali@google.com> <1414783141-6947-8-git-send-email-adityakali@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Aditya. On Mon, Nov 03, 2014 at 03:12:28PM -0800, Aditya Kali wrote: > I think the sane-behavior flag is only temporary and will be removed > anyways, right? So I didn't bother asking user to supply it. But I can > make the change as you suggested. We just have to make sure that tasks > inside cgroupns cannot mount non-default hierarchies as it would be a > regression. I'm not sure whether supporting mounting from inside a ns is even necessary but, if it is, can't you just test against cgrp_dfl_root? There's no reason to do anything differnetly for ns mounting. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCHv2 7/7] cgroup: mount cgroupns-root when inside non-init cgroupns Date: Tue, 4 Nov 2014 08:57:26 -0500 Message-ID: <20141104135726.GB14014@htj.dyndns.org> References: <1414783141-6947-1-git-send-email-adityakali@google.com> <1414783141-6947-8-git-send-email-adityakali@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Aditya Kali Cc: Andy Lutomirski , Li Zefan , Serge Hallyn , "Eric W. Biederman" , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux API , Ingo Molnar , Linux Containers , Rohit Jnagal List-Id: linux-api@vger.kernel.org Hello, Aditya. On Mon, Nov 03, 2014 at 03:12:28PM -0800, Aditya Kali wrote: > I think the sane-behavior flag is only temporary and will be removed > anyways, right? So I didn't bother asking user to supply it. But I can > make the change as you suggested. We just have to make sure that tasks > inside cgroupns cannot mount non-default hierarchies as it would be a > regression. I'm not sure whether supporting mounting from inside a ns is even necessary but, if it is, can't you just test against cgrp_dfl_root? There's no reason to do anything differnetly for ns mounting. Thanks. -- tejun