From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>, Josh Boyer <jwboyer@redhat.com>,
Sean Paul <seanpaul@chromium.org>,
Inki Dae <inki.dae@samsung.com>, Dave Airlie <airlied@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
Lucas Stach <l.stach@pengutronix.de>,
Zubair.Kakakhel@imgtec.com, djkurtz@google.com,
ykk@rock-chips.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 0/2] make imx hdmi publicly used by dw hdmi compatible platform
Date: Tue, 4 Nov 2014 14:29:09 +0000 [thread overview]
Message-ID: <20141104142908.GG4042@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1415107992-34289-1-git-send-email-andy.yan@rock-chips.com>
On Tue, Nov 04, 2014 at 09:33:10PM +0800, Andy Yan wrote:
> From: Andy yan <andy.yan@rock-chips.com>
>
> We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
> use the interface compatible Designware HDMI IP, but they also have some
> lightly difference, such as phy pll configuration, register width(imx hdmi
> register is one byte, but rk3288 is 4 bytes width and can only access by word),
> 4K support(imx6 doesn't support 4k, but rk3288 does).
>
> To reuse the imx-hdmi driver, we do this patch set:
> patch (1): split out imx-soc code from imx-hdmi to dw_hdmi-imx.c
> patch (2): move imx-hdmi to bridge/, and rename to dw-hdmi to
> make this driver indepent of drm-imx . And we will add rockchip
> platform specific code dw_hdmi-rockchip.c later, this is depend
> on drm-rockchip.
Great - I fully agree that this needs to be renamed as it is a Designware
IP.
Should it be moved into bridge/ ? It isn't implemented as a DRM bridge
driver at present, so this seems illogical. Is the longer term plan to
convert it to be a DRM bridge?
Secondly, if you want HDMI audio support, you may find the patches I
maintain for the SolidRun devices useful, which add this as a standard
ALSA device. I also have CEC support for it as well. If you're
interested, I'll email those.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: heiko@sntech.de, dri-devel@lists.freedesktop.org,
ykk@rock-chips.com, devel@driverdev.osuosl.org,
linux-rockchip@lists.infradead.org,
Grant Likely <grant.likely@linaro.org>,
Dave Airlie <airlied@redhat.com>,
devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
fabio.estevam@freescale.com, Josh Boyer <jwboyer@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, djkurtz@google.com
Subject: Re: [PATCH 0/2] make imx hdmi publicly used by dw hdmi compatible platform
Date: Tue, 4 Nov 2014 14:29:09 +0000 [thread overview]
Message-ID: <20141104142908.GG4042@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1415107992-34289-1-git-send-email-andy.yan@rock-chips.com>
On Tue, Nov 04, 2014 at 09:33:10PM +0800, Andy Yan wrote:
> From: Andy yan <andy.yan@rock-chips.com>
>
> We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
> use the interface compatible Designware HDMI IP, but they also have some
> lightly difference, such as phy pll configuration, register width(imx hdmi
> register is one byte, but rk3288 is 4 bytes width and can only access by word),
> 4K support(imx6 doesn't support 4k, but rk3288 does).
>
> To reuse the imx-hdmi driver, we do this patch set:
> patch (1): split out imx-soc code from imx-hdmi to dw_hdmi-imx.c
> patch (2): move imx-hdmi to bridge/, and rename to dw-hdmi to
> make this driver indepent of drm-imx . And we will add rockchip
> platform specific code dw_hdmi-rockchip.c later, this is depend
> on drm-rockchip.
Great - I fully agree that this needs to be renamed as it is a Designware
IP.
Should it be moved into bridge/ ? It isn't implemented as a DRM bridge
driver at present, so this seems illogical. Is the longer term plan to
convert it to be a DRM bridge?
Secondly, if you want HDMI audio support, you may find the patches I
maintain for the SolidRun devices useful, which add this as a standard
ALSA device. I also have CEC support for it as well. If you're
interested, I'll email those.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-11-04 14:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 13:33 [PATCH 0/2] make imx hdmi publicly used by dw hdmi compatible platform Andy Yan
2014-11-04 13:33 ` Andy Yan
2014-11-04 13:33 ` [PATCH 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi Andy Yan
2014-11-04 13:33 ` Andy Yan
2014-11-04 14:23 ` Zubair Lutfullah Kakakhel
2014-11-04 14:23 ` Zubair Lutfullah Kakakhel
2014-11-04 14:29 ` Russell King - ARM Linux [this message]
2014-11-04 14:29 ` [PATCH 0/2] make imx hdmi publicly used by dw hdmi compatible platform Russell King - ARM Linux
2014-11-05 2:12 ` Andy Yan
2014-11-05 2:12 ` Andy Yan
2014-11-06 9:35 ` Kuankuan.Yang
2014-11-06 9:35 ` Kuankuan.Yang
2014-11-06 10:18 ` Russell King - ARM Linux
2014-11-06 10:18 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104142908.GG4042@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=andy.yan@rock-chips.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=inki.dae@samsung.com \
--cc=jwboyer@redhat.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
--cc=shawn.guo@linaro.org \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.