From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] xen/arm: Return correct code error for xen_swiotlb_map_page Date: Fri, 7 Nov 2014 09:45:17 -0500 Message-ID: <20141107144517.GA13259__28097.4119705663$1415389750$gmane$org@laptop.dumpdata.com> References: <1415293651-13917-1-git-send-email-frediano.ziglio@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XmpUv-0002pa-9C for xen-devel@lists.xenproject.org; Fri, 07 Nov 2014 19:47:05 +0000 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: linux-kernel@vger.kernel.org, Frediano Ziglio , David Vrabel , xen-devel@lists.xenproject.org, Boris Ostrovsky , Frediano Ziglio List-Id: xen-devel@lists.xenproject.org On Thu, Nov 06, 2014 at 07:14:51PM +0000, Stefano Stabellini wrote: > On Thu, 6 Nov 2014, Frediano Ziglio wrote: > > 2014-11-06 17:30 GMT+00:00 Stefano Stabellini : > > On Thu, 6 Nov 2014, Frediano Ziglio wrote: > > > On ARM error code is not 0 so avoid to return it as error. > > > > > > Signed-off-by: Frediano Ziglio > > = > > Acked-by: Stefano Stabellini > > = > > = > > Could you please fix the same error in lib/swiotlb.c too please? > > = > > = > > Same patch or another ? > > = > = > Another It might break the build. Please double-check that it does not affect ia64. > = > > =A0 > > >=A0 drivers/xen/swiotlb-xen.c | 2 +- > > >=A0 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xe= n.c > > > index ebd8f21..3b8d628 100644 > > > --- a/drivers/xen/swiotlb-xen.c > > > +++ b/drivers/xen/swiotlb-xen.c > > > @@ -425,7 +425,7 @@ dma_addr_t xen_swiotlb_map_page(struct devi= ce *dev, struct page *page, > > >=A0 =A0 =A0 =A0 */ > > >=A0 =A0 =A0 =A0if (!dma_capable(dev, dev_addr, size)) { > > >=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0swiotlb_tbl_unmap_single(dev, map= , size, dir); > > > -=A0 =A0 =A0 =A0 =A0 =A0 =A0dev_addr =3D 0; > > > +=A0 =A0 =A0 =A0 =A0 =A0 =A0dev_addr =3D DMA_ERROR_CODE; That looks Ok to me. > > >=A0 =A0 =A0 =A0} > > >=A0 =A0 =A0 =A0return dev_addr; > > >=A0 } > > > -- > > > 1.9.1 > > > > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux= -kernel" in > > > the body of a message to majordomo@vger.kernel.org > > > More majordomo info at=A0 http://vger.kernel.org/majordomo-info= .html > > > Please read the FAQ at=A0http://secure-web.cisco.com/1cvjROyUxV= 6SnA0uBTMRubqrQWsaXGhps-FWjY3vly9AxaKKlt2DPY7GjL0FCHeP4rsbjKsc-P4zH2_7-kpcx= wEH-udGrGCCq > > kCLlH1-fLOo1X6Nlui6EwEVHUpB2r7gt-Gsgxbep9QWPnIdypDPNf8Hf5clxCMXYc= vWsOK5s3qg/http%3A%2F%2Fwww.tux.org%2Flkml%2F > > > > > = > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xen.org > > http://lists.xen.org/xen-devel > > = > > = > > = > > = > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel