From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753460AbaKLVPB (ORCPT ); Wed, 12 Nov 2014 16:15:01 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:23495 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753318AbaKLVPA (ORCPT ); Wed, 12 Nov 2014 16:15:00 -0500 Date: Thu, 13 Nov 2014 00:14:38 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, trivial@kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Coccinelle Subject: Re: [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical() Message-ID: <20141112211438.GI6749@mwanda> References: <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <544954FD.8040607@users.sourceforge.net> <20141029084702.GA18675@kroah.com> <5453CD0D.9010206@users.sourceforge.net> <5463C10D.6020409@users.sourceforge.net> <5463C373.5050804@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5463C373.5050804@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 12, 2014 at 09:30:43PM +0100, SF Markus Elfring wrote: > From: Markus Elfring Please fix your email client instead. > + goto cleanup1; 1) Don't use GW-BASIC label names. Label names should reflect what the label does such as free_fuse_word or free_fuse_tabel. 2) Don't use do-nothing labels. Just return directly. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 12 Nov 2014 21:14:38 +0000 Subject: Re: [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical() Message-Id: <20141112211438.GI6749@mwanda> List-Id: References: <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <544954FD.8040607@users.sourceforge.net> <20141029084702.GA18675@kroah.com> <5453CD0D.9010206@users.sourceforge.net> <5463C10D.6020409@users.sourceforge.net> <5463C373.5050804@users.sourceforge.net> In-Reply-To: <5463C373.5050804@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cocci@systeme.lip6.fr On Wed, Nov 12, 2014 at 09:30:43PM +0100, SF Markus Elfring wrote: > From: Markus Elfring Please fix your email client instead. > + goto cleanup1; 1) Don't use GW-BASIC label names. Label names should reflect what the label does such as free_fuse_word or free_fuse_tabel. 2) Don't use do-nothing labels. Just return directly. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: dan.carpenter@oracle.com (Dan Carpenter) Date: Thu, 13 Nov 2014 00:14:38 +0300 Subject: [Cocci] [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical() In-Reply-To: <5463C373.5050804@users.sourceforge.net> References: <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <544954FD.8040607@users.sourceforge.net> <20141029084702.GA18675@kroah.com> <5453CD0D.9010206@users.sourceforge.net> <5463C10D.6020409@users.sourceforge.net> <5463C373.5050804@users.sourceforge.net> Message-ID: <20141112211438.GI6749@mwanda> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr On Wed, Nov 12, 2014 at 09:30:43PM +0100, SF Markus Elfring wrote: > From: Markus Elfring Please fix your email client instead. > + goto cleanup1; 1) Don't use GW-BASIC label names. Label names should reflect what the label does such as free_fuse_word or free_fuse_tabel. 2) Don't use do-nothing labels. Just return directly. regards, dan carpenter