From: Wanpeng Li <wanpeng.li@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@arm.com>,
Wanpeng Li <wanpeng.li@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Kirill Tkhai <ktkhai@parallels.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug
Date: Thu, 13 Nov 2014 07:02:17 +0800 [thread overview]
Message-ID: <20141112230217.GB23249@kernel> (raw)
In-Reply-To: <20141112153906.GL29390@twins.programming.kicks-ass.net>
Hi Peter,
On Wed, Nov 12, 2014 at 04:39:06PM +0100, Peter Zijlstra wrote:
>On Wed, Nov 12, 2014 at 03:08:44PM +0000, Juri Lelli wrote:
>> > @@ -1185,8 +1223,9 @@ static int find_later_rq(struct task_struct *task)
>> > * We have to consider system topology and task affinity
>> > * first, then we can look for a suitable cpu.
>> > */
>> > - cpumask_copy(later_mask, task_rq(task)->rd->span);
>> > - cpumask_and(later_mask, later_mask, cpu_active_mask);
>> > + cpumask_copy(later_mask, cpu_active_mask);
>> > + if (likely(task_rq(task)->online))
>> > + cpumask_and(later_mask, later_mask, task_rq(task)->rd->span);
>>
>> So, here you consider the span only when the task_rq is online,
>> but there might be others cpus still online belonging to the same
>> rd->span. And you have to consider them when migrating. Actually,
>> migration must still be restricted to the online cpus of task's
>> original rd->span, or I fear you can break clustered scheduling.
>
>Ah, good point that, we must somehow find the right root domain to
>'restore' the task to. Now I'm not entirely sure we still have this.
>Lemme ponder that.
Any idea is a great appreciated. :-)
Regards,
Wanpeng Li
next prev parent reply other threads:[~2014-11-12 23:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 1:06 [PATCH v5] sched/deadline: support dl task migration during cpu hotplug Wanpeng Li
2014-11-12 15:08 ` Juri Lelli
2014-11-12 15:39 ` Peter Zijlstra
2014-11-12 23:02 ` Wanpeng Li [this message]
2015-01-05 14:52 ` Peter Zijlstra
2015-01-06 2:14 ` Wanpeng Li
2014-11-12 23:22 ` Wanpeng Li
2014-11-18 23:18 ` Wanpeng Li
2014-11-19 10:13 ` Juri Lelli
2014-11-19 12:30 ` Wanpeng Li
2014-11-19 13:49 ` Juri Lelli
2014-11-19 23:08 ` Wanpeng Li
2014-11-12 16:27 ` Kirill Tkhai
2014-11-12 22:56 ` Wanpeng Li
2014-11-13 10:10 ` Kirill Tkhai
2014-11-13 10:19 ` Wanpeng Li
2014-11-13 10:21 ` Kirill Tkhai
2014-11-16 22:59 ` Wanpeng Li
2014-11-20 8:49 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112230217.GB23249@kernel \
--to=wanpeng.li@linux.intel.com \
--cc=juri.lelli@arm.com \
--cc=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.