From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755225AbaKPLPI (ORCPT ); Sun, 16 Nov 2014 06:15:08 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:33877 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752782AbaKPLPG (ORCPT ); Sun, 16 Nov 2014 06:15:06 -0500 Date: Sun, 16 Nov 2014 14:14:46 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: Eric Paris , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, trivial@kernel.org, Coccinelle Subject: Re: [PATCH 1/1] kernel-audit: Deletion of an unnecessary check before the function call "audit_log_end" Message-ID: <20141116111446.GA4956@mwanda> References: <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54687F1A.1010809@users.sourceforge.net> <20141116111023.GA4905@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141116111023.GA4905@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 16, 2014 at 02:10:23PM +0300, Dan Carpenter wrote: > Please don't send these to trivial, because they can introduce bugs. An example of a bug introduced is here: https://lkml.org/lkml/2014/11/3/505 regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Sun, 16 Nov 2014 11:14:46 +0000 Subject: Re: [PATCH 1/1] kernel-audit: Deletion of an unnecessary check before the function call "audit_log_e Message-Id: <20141116111446.GA4956@mwanda> List-Id: References: <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54687F1A.1010809@users.sourceforge.net> <20141116111023.GA4905@mwanda> In-Reply-To: <20141116111023.GA4905@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cocci@systeme.lip6.fr On Sun, Nov 16, 2014 at 02:10:23PM +0300, Dan Carpenter wrote: > Please don't send these to trivial, because they can introduce bugs. An example of a bug introduced is here: https://lkml.org/lkml/2014/11/3/505 regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: dan.carpenter@oracle.com (Dan Carpenter) Date: Sun, 16 Nov 2014 14:14:46 +0300 Subject: [Cocci] [PATCH 1/1] kernel-audit: Deletion of an unnecessary check before the function call "audit_log_end" In-Reply-To: <20141116111023.GA4905@mwanda> References: <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54687F1A.1010809@users.sourceforge.net> <20141116111023.GA4905@mwanda> Message-ID: <20141116111446.GA4956@mwanda> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr On Sun, Nov 16, 2014 at 02:10:23PM +0300, Dan Carpenter wrote: > Please don't send these to trivial, because they can introduce bugs. An example of a bug introduced is here: https://lkml.org/lkml/2014/11/3/505 regards, dan carpenter