From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755616AbaKSIqk (ORCPT ); Wed, 19 Nov 2014 03:46:40 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:20197 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753595AbaKSIqh (ORCPT ); Wed, 19 Nov 2014 03:46:37 -0500 Date: Wed, 19 Nov 2014 11:45:42 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: "David S. Miller" , Herbert Xu , Steffen Klassert , netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Coccinelle Subject: Re: [PATCH 1/1] net: xfrm: Deletion of an unnecessary check before the function call "ipcomp_free_tfms" Message-ID: <20141119084542.GK4905@mwanda> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546BAFF5.5020603@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <546BAFF5.5020603@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 18, 2014 at 09:45:41PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 18 Nov 2014 21:41:26 +0100 > > The ipcomp_free_tfms() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > It doesn't though... regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 19 Nov 2014 08:45:42 +0000 Subject: Re: [PATCH 1/1] net: xfrm: Deletion of an unnecessary check before the function call "ipcomp_free_tf Message-Id: <20141119084542.GK4905@mwanda> List-Id: References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546BAFF5.5020603@users.sourceforge.net> In-Reply-To: <546BAFF5.5020603@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cocci@systeme.lip6.fr On Tue, Nov 18, 2014 at 09:45:41PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 18 Nov 2014 21:41:26 +0100 > > The ipcomp_free_tfms() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > It doesn't though... regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: dan.carpenter@oracle.com (Dan Carpenter) Date: Wed, 19 Nov 2014 11:45:42 +0300 Subject: [Cocci] [PATCH 1/1] net: xfrm: Deletion of an unnecessary check before the function call "ipcomp_free_tfms" In-Reply-To: <546BAFF5.5020603@users.sourceforge.net> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546BAFF5.5020603@users.sourceforge.net> Message-ID: <20141119084542.GK4905@mwanda> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr On Tue, Nov 18, 2014 at 09:45:41PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 18 Nov 2014 21:41:26 +0100 > > The ipcomp_free_tfms() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > It doesn't though... regards, dan carpenter