All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/3] powerpc: mpc52xx: a4m072: Convert to generic board
@ 2014-11-19  8:37 Stefan Roese
  2014-11-19  8:37 ` [U-Boot] [PATCH 2/3] powerpc: mpc52xx: a3m071/a4m2k: " Stefan Roese
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Stefan Roese @ 2014-11-19  8:37 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
---
 include/configs/a4m072.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/configs/a4m072.h b/include/configs/a4m072.h
index cc88ac1..3c67655 100644
--- a/include/configs/a4m072.h
+++ b/include/configs/a4m072.h
@@ -19,6 +19,8 @@
 #define CONFIG_MPC5200		1	/* This is a MPC5200 CPU */
 #define CONFIG_A4M072		1	/* ... on A4M072 board */
 #define CONFIG_MPC5200_DDR	1	/* ... use DDR RAM */
+#define CONFIG_DISPLAY_BOARDINFO
+#define CONFIG_SYS_GENERIC_BOARD
 
 #define CONFIG_SYS_TEXT_BASE	0xFE000000
 
-- 
2.1.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH 2/3] powerpc: mpc52xx: a3m071/a4m2k: Convert to generic board
  2014-11-19  8:37 [U-Boot] [PATCH 1/3] powerpc: mpc52xx: a4m072: Convert to generic board Stefan Roese
@ 2014-11-19  8:37 ` Stefan Roese
  2014-11-19 12:08   ` Wolfgang Denk
  2014-11-19  8:37 ` [U-Boot] [PATCH 3/3] powerpc: mpc52xx: Clear GD in the main U-Boot stage for SPL usage Stefan Roese
  2014-11-19 12:07 ` [U-Boot] [PATCH 1/3] powerpc: mpc52xx: a4m072: Convert to generic board Wolfgang Denk
  2 siblings, 1 reply; 6+ messages in thread
From: Stefan Roese @ 2014-11-19  8:37 UTC (permalink / raw)
  To: u-boot

a3m071 and a4m2k share one config header. So adding the generic board defines
in this one file is enough to convert both boards.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
---
 include/configs/a3m071.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/configs/a3m071.h b/include/configs/a3m071.h
index a4050f3..120fdc6 100644
--- a/include/configs/a3m071.h
+++ b/include/configs/a3m071.h
@@ -14,6 +14,8 @@
 
 #define CONFIG_MPC5200
 #define CONFIG_A3M071			/* A3M071 board */
+#define CONFIG_DISPLAY_BOARDINFO
+#define CONFIG_SYS_GENERIC_BOARD
 
 #define	CONFIG_SYS_TEXT_BASE	0x01000000	/* boot low for 32 MiB boards */
 
-- 
2.1.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH 3/3] powerpc: mpc52xx: Clear GD in the main U-Boot stage for SPL usage
  2014-11-19  8:37 [U-Boot] [PATCH 1/3] powerpc: mpc52xx: a4m072: Convert to generic board Stefan Roese
  2014-11-19  8:37 ` [U-Boot] [PATCH 2/3] powerpc: mpc52xx: a3m071/a4m2k: " Stefan Roese
@ 2014-11-19  8:37 ` Stefan Roese
  2014-11-19 12:09   ` Wolfgang Denk
  2014-11-19 12:07 ` [U-Boot] [PATCH 1/3] powerpc: mpc52xx: a4m072: Convert to generic board Wolfgang Denk
  2 siblings, 1 reply; 6+ messages in thread
From: Stefan Roese @ 2014-11-19  8:37 UTC (permalink / raw)
  To: u-boot

When an MPC5200 based board is used with SPL support, the main
U-Boot needs to clear the GD (global data) struct again.

Otherwise the generic board init code in board_init_f (when
CONFIG_SYS_GENERIC_BOARD is defined) will not initialize all
GD variables correctly. Resulting in a hangup on the a4m2k
board.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
---
 arch/powerpc/cpu/mpc5xxx/start.S | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/powerpc/cpu/mpc5xxx/start.S b/arch/powerpc/cpu/mpc5xxx/start.S
index 02c706e..94eb0d3 100644
--- a/arch/powerpc/cpu/mpc5xxx/start.S
+++ b/arch/powerpc/cpu/mpc5xxx/start.S
@@ -76,6 +76,21 @@ _start:
 	 * been done in the SPL u-boot version.
 	 */
 	GET_GOT			/* initialize GOT access		*/
+
+	/*
+	 * The GD (global data) struct needs to get cleared. Lets do
+	 * this by calling memset().
+	 * This function is called when the platform is build with SPL
+	 * support from the main (full-blown) U-Boot. And the GD needs
+	 * to get cleared (again) so that the following generic
+	 * board support code, defined via CONFIG_SYS_GENERIC_BOARD,
+	 * initializes all variables correctly.
+	 */
+	mr	r3, r2		/* parameter 1:	 GD pointer		*/
+	li	r4,0		/* parameter 2:	 value to fill		*/
+	li	r5,GD_SIZE	/* parameter 3:	 count			*/
+	bl	memset
+
 	bl	board_init_f	/* run 1st part of board init code (in Flash)*/
 	/* NOTREACHED - board_init_f() does not return */
 #else
-- 
2.1.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH 1/3] powerpc: mpc52xx: a4m072: Convert to generic board
  2014-11-19  8:37 [U-Boot] [PATCH 1/3] powerpc: mpc52xx: a4m072: Convert to generic board Stefan Roese
  2014-11-19  8:37 ` [U-Boot] [PATCH 2/3] powerpc: mpc52xx: a3m071/a4m2k: " Stefan Roese
  2014-11-19  8:37 ` [U-Boot] [PATCH 3/3] powerpc: mpc52xx: Clear GD in the main U-Boot stage for SPL usage Stefan Roese
@ 2014-11-19 12:07 ` Wolfgang Denk
  2 siblings, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2014-11-19 12:07 UTC (permalink / raw)
  To: u-boot

Dear Stefan Roese,

In message <1416386268-31398-1-git-send-email-sr@denx.de> you wrote:
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Wolfgang Denk <wd@denx.de>
> ---
>  include/configs/a4m072.h | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Remember that the best relationship is one in  which  your  love  for
each other exceeds your need for each other.             - Dalai Lama

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH 2/3] powerpc: mpc52xx: a3m071/a4m2k: Convert to generic board
  2014-11-19  8:37 ` [U-Boot] [PATCH 2/3] powerpc: mpc52xx: a3m071/a4m2k: " Stefan Roese
@ 2014-11-19 12:08   ` Wolfgang Denk
  0 siblings, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2014-11-19 12:08 UTC (permalink / raw)
  To: u-boot

Dear Stefan Roese,

In message <1416386268-31398-2-git-send-email-sr@denx.de> you wrote:
> a3m071 and a4m2k share one config header. So adding the generic board defines
> in this one file is enough to convert both boards.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Wolfgang Denk <wd@denx.de>
> ---
>  include/configs/a3m071.h | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
For every complex problem, there is a solution that is simple,  neat,
and wrong.                                               - Mark Twain

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH 3/3] powerpc: mpc52xx: Clear GD in the main U-Boot stage for SPL usage
  2014-11-19  8:37 ` [U-Boot] [PATCH 3/3] powerpc: mpc52xx: Clear GD in the main U-Boot stage for SPL usage Stefan Roese
@ 2014-11-19 12:09   ` Wolfgang Denk
  0 siblings, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2014-11-19 12:09 UTC (permalink / raw)
  To: u-boot

Dear Stefan Roese,

In message <1416386268-31398-3-git-send-email-sr@denx.de> you wrote:
> When an MPC5200 based board is used with SPL support, the main
> U-Boot needs to clear the GD (global data) struct again.
> 
> Otherwise the generic board init code in board_init_f (when
> CONFIG_SYS_GENERIC_BOARD is defined) will not initialize all
> GD variables correctly. Resulting in a hangup on the a4m2k
> board.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Wolfgang Denk <wd@denx.de>
> ---
>  arch/powerpc/cpu/mpc5xxx/start.S | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Do not simplify the design of a program if a way can be found to make
it complex and wonderful.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-11-19 12:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-19  8:37 [U-Boot] [PATCH 1/3] powerpc: mpc52xx: a4m072: Convert to generic board Stefan Roese
2014-11-19  8:37 ` [U-Boot] [PATCH 2/3] powerpc: mpc52xx: a3m071/a4m2k: " Stefan Roese
2014-11-19 12:08   ` Wolfgang Denk
2014-11-19  8:37 ` [U-Boot] [PATCH 3/3] powerpc: mpc52xx: Clear GD in the main U-Boot stage for SPL usage Stefan Roese
2014-11-19 12:09   ` Wolfgang Denk
2014-11-19 12:07 ` [U-Boot] [PATCH 1/3] powerpc: mpc52xx: a4m072: Convert to generic board Wolfgang Denk

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.