From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrB7F-0004ua-Mu for qemu-devel@nongnu.org; Wed, 19 Nov 2014 14:40:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrB7B-00005W-Kf for qemu-devel@nongnu.org; Wed, 19 Nov 2014 14:40:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrB7B-00004x-Ap for qemu-devel@nongnu.org; Wed, 19 Nov 2014 14:40:33 -0500 Date: Wed, 19 Nov 2014 19:40:20 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20141119194019.GT2355@work-vm> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-46-git-send-email-dgilbert@redhat.com> <20141113032915.GG7291@voom.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141113032915.GG7291@voom.fritz.box> Subject: Re: [Qemu-devel] [PATCH v4 45/47] Start up a postcopy/listener thread ready for incoming page data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com * David Gibson (david@gibson.dropbear.id.au) wrote: > On Fri, Oct 03, 2014 at 06:47:51PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The loading of a device state (during postcopy) may access guest > > memory that's still on the source machine and thus might need > > a page fill; split off a separate thread that handles the incoming > > page data so that the original incoming migration code can finish > > off the device data. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > include/migration/migration.h | 4 +++ > > migration.c | 6 +++++ > > savevm.c | 62 +++++++++++++++++++++++++++++++++++++++++-- > > 3 files changed, 70 insertions(+), 2 deletions(-) > > > > diff --git a/include/migration/migration.h b/include/migration/migration.h > > index 00255b8..69e776c 100644 > > --- a/include/migration/migration.h > > +++ b/include/migration/migration.h > > @@ -92,6 +92,10 @@ struct MigrationIncomingState { > > QemuThread fault_thread; > > QemuSemaphore fault_thread_sem; > > > > + bool have_listen_thread; > > AFAICT have_listen_thread is never set to a value other than 'true', > so there doesn't see much point to it. It's tested by qemu_loadvm_state to avoid doing cleaning stuff up as it exits, since the listen thread is still using it. Dave > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK