From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752616AbaKUUTf (ORCPT ); Fri, 21 Nov 2014 15:19:35 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:38458 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752319AbaKUUO4 (ORCPT ); Fri, 21 Nov 2014 15:14:56 -0500 Date: Fri, 21 Nov 2014 15:14:53 -0500 (EST) Message-Id: <20141121.151453.2056435337330014938.davem@davemloft.net> To: elfring@users.sourceforge.net Cc: michal.simek@xilinx.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH 1/1] net: Xilinx: Deletion of unnecessary checks before two function calls From: David Miller In-Reply-To: <546DF1A2.8090208@users.sourceforge.net> References: <5317A59D.4@users.sourceforge.net> <546DF1A2.8090208@users.sourceforge.net> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Fri, 21 Nov 2014 12:14:55 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: SF Markus Elfring Date: Thu, 20 Nov 2014 14:50:26 +0100 > From: Markus Elfring > Date: Thu, 20 Nov 2014 14:47:12 +0100 > > The functions kfree() and of_node_put() test whether their argument is NULL > and then return immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/1] net: Xilinx: Deletion of unnecessary checks before two function calls Date: Fri, 21 Nov 2014 15:14:53 -0500 (EST) Message-ID: <20141121.151453.2056435337330014938.davem@davemloft.net> References: <5317A59D.4@users.sourceforge.net> <546DF1A2.8090208@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr, linux-arm-kernel@lists.infradead.org To: elfring@users.sourceforge.net Return-path: In-Reply-To: <546DF1A2.8090208@users.sourceforge.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org From: SF Markus Elfring Date: Thu, 20 Nov 2014 14:50:26 +0100 > From: Markus Elfring > Date: Thu, 20 Nov 2014 14:47:12 +0100 > > The functions kfree() and of_node_put() test whether their argument is NULL > and then return immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Fri, 21 Nov 2014 20:14:53 +0000 Subject: Re: [PATCH 1/1] net: Xilinx: Deletion of unnecessary checks before two function calls Message-Id: <20141121.151453.2056435337330014938.davem@davemloft.net> List-Id: References: <5317A59D.4@users.sourceforge.net> <546DF1A2.8090208@users.sourceforge.net> In-Reply-To: <546DF1A2.8090208@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org From: SF Markus Elfring Date: Thu, 20 Nov 2014 14:50:26 +0100 > From: Markus Elfring > Date: Thu, 20 Nov 2014 14:47:12 +0100 > > The functions kfree() and of_node_put() test whether their argument is NULL > and then return immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: davem@davemloft.net (David Miller) Date: Fri, 21 Nov 2014 15:14:53 -0500 (EST) Subject: [PATCH 1/1] net: Xilinx: Deletion of unnecessary checks before two function calls In-Reply-To: <546DF1A2.8090208@users.sourceforge.net> References: <5317A59D.4@users.sourceforge.net> <546DF1A2.8090208@users.sourceforge.net> Message-ID: <20141121.151453.2056435337330014938.davem@davemloft.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org From: SF Markus Elfring Date: Thu, 20 Nov 2014 14:50:26 +0100 > From: Markus Elfring > Date: Thu, 20 Nov 2014 14:47:12 +0100 > > The functions kfree() and of_node_put() test whether their argument is NULL > and then return immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied.