From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH v5 4/7] hash: add rte_hash_crc_8byte function Date: Fri, 21 Nov 2014 06:22:42 -0500 Message-ID: <20141121112242.GA20661@hmsreliant.think-freely.org> References: <1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz> <5bc163e39a2e8176f7e0b424c70bb051d2f5a0a8.1416459284.git.e_zhumabekov@sts.kz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev-VfR2kkLFssw@public.gmane.org To: Yerden Zhumabekov Return-path: Content-Disposition: inline In-Reply-To: <5bc163e39a2e8176f7e0b424c70bb051d2f5a0a8.1416459284.git.e_zhumabekov-8EHiFRVJVgQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Thu, Nov 20, 2014 at 11:16:34AM +0600, Yerden Zhumabekov wrote: > SSE4.2 provides CRC32 intrinsic with 8-byte operand. > > Signed-off-by: Yerden Zhumabekov > --- > lib/librte_hash/rte_hash_crc.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/lib/librte_hash/rte_hash_crc.h b/lib/librte_hash/rte_hash_crc.h > index cd28833..2c8ec99 100644 > --- a/lib/librte_hash/rte_hash_crc.h > +++ b/lib/librte_hash/rte_hash_crc.h > @@ -413,6 +413,22 @@ rte_hash_crc_4byte(uint32_t data, uint32_t init_val) > } > > /** > + * Use single crc32 instruction to perform a hash on a 8 byte value. > + * > + * @param data > + * Data to perform hash on. > + * @param init_val > + * Value to initialise hash generator. > + * @return > + * 32bit calculated hash value. > + */ > +static inline uint32_t > +rte_hash_crc_8byte(uint64_t data, uint32_t init_val) > +{ > + return crc32c_sse42_u64(data, init_val); > +} > + > +/** > * Use crc32 instruction to perform a hash. > * > * @param data > -- > 1.7.9.5 > > I'm sorry, it may be early here, so I may be missing something. The assembly implementations look great, but if a user calls rte_hash_crc_8byte on a system that doesn't support ss342, how do they wind up getting into the software crc implementation given what you have above? Neil