From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mpdecimal: disable static build
Date: Sun, 23 Nov 2014 23:15:18 +0100 [thread overview]
Message-ID: <20141123221518.GM11143@free.fr> (raw)
In-Reply-To: <235ca63e3c273ed4feb8d39cfbb5c05b1fe50d0f.1416733726.git.baruch@tkos.co.il>
Baruch, All,
On 2014-11-23 11:08 +0200, Baruch Siach spake thusly:
> mpdecimal always tries to build its shared library.
>
> Fixes:
> http://autobuild.buildroot.net/results/276/2764bd8c42ba659682760ffc6afa933b7530d06c/
> http://autobuild.buildroot.net/results/3cc/3cca0aacc4d66c49b21d23681813abea5a1b32e0/
> http://autobuild.buildroot.net/results/207/20783d1448464d957862e1c70585844f86aed237/
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Beside the fact that Thomas P. has a fix for building static, I have a
comment on that patch of yours...
> ---
> package/mpdecimal/Config.in | 4 ++++
> package/python3/Config.in | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/package/mpdecimal/Config.in b/package/mpdecimal/Config.in
> index 929d41514399..2aae520c15d9 100644
> --- a/package/mpdecimal/Config.in
> +++ b/package/mpdecimal/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_MPDECIMAL
> bool "mpdecimal"
> help
> + depends on !BR2_PREFER_STATIC_LIB
> mpdecimal is a package for correctly-rounded arbitrary
> precision decimal floating point arithmetic. Starting from
> version 2.4, mpdecimal includes only the libmpdec
Really? This makes the "depends on" part of the help text...
Regards,
Yann E. MORIN.
> @@ -8,3 +9,6 @@ config BR2_PACKAGE_MPDECIMAL
> exclusively on libmpdec.
>
> http://www.bytereef.org/mpdecimal/
> +
> +comment "mpdecimal needs a toolchain w/ dynamic library"
> + depends on BR2_PREFER_STATIC_LIB
> diff --git a/package/python3/Config.in b/package/python3/Config.in
> index 375390fcf69d..afcb74229474 100644
> --- a/package/python3/Config.in
> +++ b/package/python3/Config.in
> @@ -57,10 +57,14 @@ config BR2_PACKAGE_PYTHON3_CURSES
>
> config BR2_PACKAGE_PYTHON3_DECIMAL
> select BR2_PACKAGE_MPDECIMAL
> + depends on !BR2_PREFER_STATIC_LIB # mpdecimal
> bool "decimal module"
> help
> decimal module for Python3.
>
> +comment "decimal module needs a toolchain w/ dynamic library"
> + depends on BR2_PREFER_STATIC_LIB
> +
> config BR2_PACKAGE_PYTHON3_PYEXPAT
> select BR2_PACKAGE_EXPAT
> bool "pyexpat"
> --
> 2.1.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-11-23 22:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 9:08 [Buildroot] [PATCH] mpdecimal: disable static build Baruch Siach
2014-11-23 9:47 ` Thomas Petazzoni
2014-11-23 22:15 ` Yann E. MORIN [this message]
2014-11-24 4:33 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141123221518.GM11143@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.