From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Subject: Re: [PATCH v2] thermal:core:fix: Check return code of the ->get_max_state() callback Date: Mon, 24 Nov 2014 15:24:49 +0100 Message-ID: <20141124152449.595d5d34@amdc2363> References: <1415898165-27406-1-git-send-email-l.majewski@samsung.com> <1416305790-27746-1-git-send-email-l.majewski@samsung.com> <20141121180826.GA3331@developer> <20141124113854.36975fb2@amdc2363> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-reply-to: Sender: linux-kernel-owner@vger.kernel.org To: Viresh Kumar Cc: Eduardo Valentin , Zhang Rui , Ezequiel Garcia , Kuninori Morimoto , Linux PM list , Vincenzo Frascino , Bartlomiej Zolnierkiewicz , Lukasz Majewski , Nobuhiro Iwamatsu , Mikko Perttunen , Stephen Warren , Thierry Reding , Alexandre Courbot , "linux-tegra@vger.kernel.org" , Linux Kernel Mailing List List-Id: linux-tegra@vger.kernel.org Hi Viresh, > On 24 November 2014 at 16:08, Lukasz Majewski > wrote: > > As I look into the cpufreq-dt.c driver - in the cpufreq_init() > > function, the call to of_cpufreq_cooling_register() is performed > > just before cpufreq_table_validate_and_show(). > > It looks like a mistake in the cpufreq-dt.c code. > > Yes. Just fixed it up and sent a patch. Please provide your > tested-by's.. Thanks for your prompt response. I don't have board which uses both of-thermal.c and cpufreq-dt.c (exynos uses old approach for cpufreq). I think that Eduardo may have some boards for testing. Regarding the patch: Reviewed-by: Lukasz Majewski -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group