From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752287AbaKZGuP (ORCPT ); Wed, 26 Nov 2014 01:50:15 -0500 Received: from mail-pd0-f177.google.com ([209.85.192.177]:64179 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245AbaKZGuN (ORCPT ); Wed, 26 Nov 2014 01:50:13 -0500 Date: Tue, 25 Nov 2014 22:50:09 -0800 From: Brian Norris To: SF Markus Elfring Cc: David Woodhouse , linux-mtd@lists.infradead.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 1/1] MTD: Deletion of unnecessary checks before two function calls Message-ID: <20141126064910.GJ3212@norris-Latitude-E6410> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546DE4BB.3000900@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <546DE4BB.3000900@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 20, 2014 at 01:55:23PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 20 Nov 2014 13:50:43 +0100 > > The functions kfree() and pci_dev_put() test whether their argument is NULL > and then return immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied to l2-mtd.git. Brian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Date: Wed, 26 Nov 2014 06:50:09 +0000 Subject: Re: [PATCH 1/1] MTD: Deletion of unnecessary checks before two function calls Message-Id: <20141126064910.GJ3212@norris-Latitude-E6410> List-Id: References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546DE4BB.3000900@users.sourceforge.net> In-Reply-To: <546DE4BB.3000900@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org, David Woodhouse , LKML , Julia Lawall On Thu, Nov 20, 2014 at 01:55:23PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 20 Nov 2014 13:50:43 +0100 > > The functions kfree() and pci_dev_put() test whether their argument is NULL > and then return immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied to l2-mtd.git. Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pd0-x234.google.com ([2607:f8b0:400e:c02::234]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XtWQs-0004lh-Kp for linux-mtd@lists.infradead.org; Wed, 26 Nov 2014 06:50:35 +0000 Received: by mail-pd0-f180.google.com with SMTP id p10so2197483pdj.25 for ; Tue, 25 Nov 2014 22:50:13 -0800 (PST) Date: Tue, 25 Nov 2014 22:50:09 -0800 From: Brian Norris To: SF Markus Elfring Subject: Re: [PATCH 1/1] MTD: Deletion of unnecessary checks before two function calls Message-ID: <20141126064910.GJ3212@norris-Latitude-E6410> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546DE4BB.3000900@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <546DE4BB.3000900@users.sourceforge.net> Cc: linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org, David Woodhouse , LKML , Julia Lawall List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Nov 20, 2014 at 01:55:23PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 20 Nov 2014 13:50:43 +0100 > > The functions kfree() and pci_dev_put() test whether their argument is NULL > and then return immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied to l2-mtd.git. Brian