From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] scripts: fix symbol overriding in configuration files Date: Fri, 28 Nov 2014 13:56:04 +0000 Message-ID: <20141128135604.GB5828@bricha3-MOBL3> References: <1417087745-9004-1-git-send-email-david.marchand@6wind.com> <4256507.tIOyuODinC@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: Content-Disposition: inline In-Reply-To: <4256507.tIOyuODinC@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Thu, Nov 27, 2014 at 10:17:22AM -0800, Thomas Monjalon wrote: > > When redefining the same symbol in configuration (basically after an inclusion), > > we need to undefine the previous symbol to avoid "redefined" errors. > > > > Signed-off-by: David Marchand > > Acked-by: Thomas Monjalon > > Applied > This patch doesn't seem to work on FreeBSD. I'm still investigating how to fix it but right now compilation with gcc/clang on FreeBSD is broken due to the config.h file having lines like the below in it :-( /usr/home/bruce/dpdk.org/x86_64-native-bsdapp-clang/include/rte_config.h:3:21: fatal error: extra tokens at end of #undef directive [-Wextra-tokens] #undef RTE_EXEC_ENVn#define RTE_EXEC_ENV "bsdapp" I'll send on a fix as soon as I can. Regards, /Bruce