From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Stephane Eranian <eranian@google.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 0/8] perf buildid-cache: Add clean command
Date: Mon, 1 Dec 2014 20:29:19 -0200 [thread overview]
Message-ID: <20141201222919.GC6774@redhat.com> (raw)
In-Reply-To: <1417460789-13874-1-git-send-email-jolsa@kernel.org>
Em Mon, Dec 01, 2014 at 08:06:21PM +0100, Jiri Olsa escreveu:
> hi,
> adding 'perf buildid-cache clean' command to allow removal
> files from '~/.debug` cache plus other fixes.
>
> Basically the clean command allows to display/remove cache
> files/sizes like:
>
> Display cache files older than 3 days:
> $ perf buildid-cache clean 3d
This is confusing, I went on parsing and the above command meant: clean
the files that are 3 days or older.
Right now we have:
usage: perf buildid-cache [<options>]
-a, --add <file list>
file(s) to add
-k, --kcore <file> kcore file to add
-r, --remove <file list>
file(s) to remove
-M, --missing <file> to find missing build ids in the cache
-f, --force don't complain, do it
-u, --update <file list>
file(s) to update
-v, --verbose be more verbose
[acme@sandy wb]$
If we keep the way it is, I think it would be clearer to add a -l/--list
command and that would:
perf buildid-cache --list # list all the files in the cache
perf buildid-cache --list 3d # list 3 days old files
perf buildid-cache --list +3d # list files 3 days or more older
perf buildid-cache --list -3d # list files up to 3 days old
And all these would print the sum of the matching files, i.e. the space
those files use in the filesystem.
> Remove cache files older than 3 days:
> $ perf buildid-cache clean 3d -r
perf buildid-cache --remove [-+]Nd # Same semantics as above
>
> Total cache removal:
> $ perf buildid-cache clean -r
perf buildid-cache --remove '*'
> Remove and display items bigger than 200M
> $ perf buildid-cache clean -r -a 200M
But yeah, perhaps we could switch to having subcommands and add:
perf buildid-cache [add|remove|update|list]
What do you think?
Also in this process, we should rename buildid-cache to a shorter form,
'cache', i.e. 'perf cache', or we can leave this for later, for Masami's
patchkit we discussed recently.
- Arnaldo
>
> Also available in here:
> git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> perf/core_buildid_cache_clean
>
> thanks,
> jirka
>
>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Stephane Eranian <eranian@google.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> Jiri Olsa (8):
> perf tools: Use single strcmp call instead of two
> perf tools: Remove extra debugdir variables
> perf tools: Add --buildid-dir option to set cache directory
> perf buildid-cache: Add clean command
> perf buildid-cache: Add automated tests
> perf buildid cache: Fix -a segfault
> perf buildid-cache: Fix kallsyms removal
> perf buildid-cache: Try to remove empty directories
>
> tools/perf/Documentation/perf-buildid-cache.txt | 59 +++++++++++
> tools/perf/Documentation/perf.txt | 4 +
> tools/perf/Makefile.perf | 7 +-
> tools/perf/builtin-buildid-cache.c | 501 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
> tools/perf/perf.c | 14 ++-
> tools/perf/tests/buildid-cache.c | 88 ++++++++++++++++
> tools/perf/tests/buildid-cache.sh | 60 +++++++++++
> tools/perf/tests/builtin-test.c | 8 ++
> tools/perf/tests/tests.h | 1 +
> tools/perf/util/build-id.c | 53 ++++++++--
> tools/perf/util/config.c | 10 +-
> tools/perf/util/util.h | 2 +-
> 12 files changed, 781 insertions(+), 26 deletions(-)
> create mode 100644 tools/perf/tests/buildid-cache.c
> create mode 100755 tools/perf/tests/buildid-cache.sh
next prev parent reply other threads:[~2014-12-01 22:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 19:06 [PATCH 0/8] perf buildid-cache: Add clean command Jiri Olsa
2014-12-01 19:06 ` [PATCH 1/8] perf tools: Use single strcmp call instead of two Jiri Olsa
2014-12-12 8:16 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2014-12-01 19:06 ` [PATCH 2/8] perf tools: Remove extra debugdir variables Jiri Olsa
2014-12-12 8:17 ` [tip:perf/urgent] perf buildid-cache: " tip-bot for Jiri Olsa
2014-12-01 19:06 ` [PATCH 3/8] perf tools: Add --buildid-dir option to set cache directory Jiri Olsa
2014-12-05 15:36 ` Arnaldo Carvalho de Melo
2014-12-12 8:17 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2014-12-01 19:06 ` [PATCH 4/8] perf buildid-cache: Add clean command Jiri Olsa
2014-12-01 19:06 ` [PATCH 5/8] perf buildid-cache: Add automated tests Jiri Olsa
2014-12-05 15:30 ` Arnaldo Carvalho de Melo
2014-12-06 12:12 ` Jiri Olsa
2014-12-01 19:06 ` [PATCH 6/8] perf buildid cache: Fix -a segfault Jiri Olsa
2014-12-05 15:30 ` Arnaldo Carvalho de Melo
2014-12-12 8:17 ` [tip:perf/urgent] perf buildid cache: Fix -a segfault related to kcore handling tip-bot for Jiri Olsa
2014-12-01 19:06 ` [PATCH 7/8] perf buildid-cache: Fix kallsyms removal Jiri Olsa
2014-12-01 19:06 ` [PATCH 8/8] perf buildid-cache: Try to remove empty directories Jiri Olsa
2014-12-01 22:29 ` Arnaldo Carvalho de Melo [this message]
2014-12-02 12:25 ` [PATCH 0/8] perf buildid-cache: Add clean command Jiri Olsa
2014-12-02 14:10 ` Arnaldo Carvalho de Melo
2014-12-03 8:13 ` Namhyung Kim
2014-12-03 13:38 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201222919.GC6774@redhat.com \
--to=acme@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.