From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH 0/7 v4] ext4: Extent status tree shrinker improvements
Date: Wed, 3 Dec 2014 09:21:18 +0100 [thread overview]
Message-ID: <20141203082118.GA8526@quack.suse.cz> (raw)
In-Reply-To: <20141203022018.GM13618@thunk.org>
On Tue 02-12-14 21:20:18, Ted Tso wrote:
> I realized I hadn't ack'ed this patch series, but since this patch
> series is an improvement on what we have now, I've included them in
> the ext4 git tree. I'm sure there's more improvements we can do on
> the shrinker, but we can use these patches as a starting point.
Yeah, I'd like to return to this as well. In particular it should be
relatively straightforward to RCUify the list of inodes with extents to
shrink and thus avoid the relatively expensive s_es_lock in the shrinker.
Additionally we could batch removal from the list of inodes with
reclaimable extents (removal would happen only in the ext4_evict_inode()
and in the shrinker when it sees say 16 inodes with zero reclaimable
extents in the list - then it would grab the lock, scan part of the list
and remove all inodes with zero reclaimable extents). I'd expect that to
significantly reduce contention on s_es_lock.
But these need more measurements and experimentation...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2014-12-03 8:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 14:55 [PATCH 0/7 v4] ext4: Extent status tree shrinker improvements Jan Kara
2014-11-25 14:55 ` [PATCH 1/7] ext4: Fix block reservation for bigalloc filesystems Jan Kara
2014-11-25 14:55 ` [PATCH 2/7] ext4: cache extent hole in extent status tree for ext4_da_map_blocks() Jan Kara
2014-11-25 14:55 ` [PATCH 3/7] ext4: change LRU to round-robin in extent status tree shrinker Jan Kara
2014-11-25 14:55 ` [PATCH 4/7] ext4: Move handling of list of shrinkable inodes into extent status code Jan Kara
2014-11-25 14:55 ` [PATCH 5/7] ext4: Limit number of scanned extents in status tree shrinker Jan Kara
2014-11-25 14:55 ` [PATCH 6/7] ext4: Cleanup flag definitions for extent status tree Jan Kara
2014-11-25 14:55 ` [PATCH 7/7] ext4: Introduce aging to " Jan Kara
2014-12-03 2:20 ` [PATCH 0/7 v4] ext4: Extent status tree shrinker improvements Theodore Ts'o
2014-12-03 8:21 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203082118.GA8526@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.