All of lore.kernel.org
 help / color / mirror / Atom feed
From: chrubis@suse.cz (Cyril Hrubis)
To: cocci@systeme.lip6.fr
Subject: [Cocci] string parameter concatenation
Date: Wed, 3 Dec 2014 09:33:52 +0100	[thread overview]
Message-ID: <20141203083352.GA9214@rei.suse.de> (raw)
In-Reply-To: <alpine.DEB.2.10.1410170752240.2654@hadrien>

Hi!
> diff --git a/parsing_c/unparse_c.ml b/parsing_c/unparse_c.ml
> index 3c54c33..77c23bb 100644
> --- a/parsing_c/unparse_c.ml
> +++ b/parsing_c/unparse_c.ml
> @@ -1288,14 +1288,12 @@ let add_newlines toks tabbing_unit =
>      | _ -> (count,List.tl stack,space_cell,seen_cocci) in
>    let update_by_stack s count stack sp space_cell seen_cocci =
>      let count = simple_string_length s (count + 1 (*space*)) in
> -    let newinfo =
> -      match stack with
> -      | [(x,tustack)] ->
> -          (match check_for_newline count x tustack space_cell with
> -          | Some count -> (stack,Some (x,sp), seen_cocci)
> -          | None -> (stack,Some (count,sp),seen_cocci))
> -      | _ -> (stack,space_cell,seen_cocci) in
> -    (newinfo,count) in
> +    match stack with
> +    | [(x,tustack)] ->
> +        (match check_for_newline count x tustack space_cell with
> +        | Some count -> ((stack,Some (x,sp), seen_cocci),count)
> +        | None -> ((stack,Some (count,sp),seen_cocci),count))
> +    | _ -> ((stack,space_cell,seen_cocci),count) in
>    let rec loop ((stack,space_cell,seen_cocci) as info) count seeneq =
>      function
>      | [] -> []

Sorry, I've lost context on this one. Over what patches should I apply
this patch? I've tried both 1.0.0-rc22 and 1.0.0-rc22 + patches you send
previously and neither of them worked :(.

It would have been easier if coccinelle had official git repository you
could have pushed the patch there and easily point me to it...

-- 
Cyril Hrubis
chrubis at suse.cz

      reply	other threads:[~2014-12-03  8:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01 13:02 [Cocci] string parameter concatenation Cyril Hrubis
2014-10-01 13:08 ` Julia Lawall
2014-10-01 13:21   ` SF Markus Elfring
2014-10-01 13:26     ` Julia Lawall
2014-10-01 18:28   ` Luis R. Rodriguez
2014-10-02  9:35   ` Cyril Hrubis
2014-10-02 10:24     ` Julia Lawall
2014-10-02 12:52 ` SF Markus Elfring
2014-10-02 13:04   ` Julia Lawall
2014-10-02 13:07   ` Cyril Hrubis
2014-10-02 13:37     ` Julia Lawall
2014-10-02 13:42       ` Cyril Hrubis
2014-10-02 17:00 ` Julia Lawall
2014-10-06 10:25   ` Cyril Hrubis
2014-10-06 10:49     ` Julia Lawall
2014-10-06 11:02       ` [Cocci] Configuration for alignment of function parameters? SF Markus Elfring
2014-10-17  5:53     ` [Cocci] string parameter concatenation Julia Lawall
2014-12-03  8:33       ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203083352.GA9214@rei.suse.de \
    --to=chrubis@suse.cz \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.