From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xw6RY-0003OC-Lj for qemu-devel@nongnu.org; Wed, 03 Dec 2014 04:42:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xw6RR-0006P5-E8 for qemu-devel@nongnu.org; Wed, 03 Dec 2014 04:41:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xw6RR-0006Oy-61 for qemu-devel@nongnu.org; Wed, 03 Dec 2014 04:41:49 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB39fmuO006012 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 3 Dec 2014 04:41:48 -0500 Date: Wed, 3 Dec 2014 17:41:45 +0800 From: Fam Zheng Message-ID: <20141203094145.GE14611@ad.nay.redhat.com> References: <1417598601-18537-1-git-send-email-mreitz@redhat.com> <1417598601-18537-3-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417598601-18537-3-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: Add test for vmdk JSON file names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi On Wed, 12/03 10:23, Max Reitz wrote: > Add a test for vmdk files which use a file with a JSON file name, and > which then try to open extents. That should fail and the error message > should at least try to look helpful. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/059 | 6 ++++++ > tests/qemu-iotests/059.out | 4 ++++ > 2 files changed, 10 insertions(+) > > diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 > index 2ed1a7f..50ca5ce 100755 > --- a/tests/qemu-iotests/059 > +++ b/tests/qemu-iotests/059 > @@ -111,6 +111,12 @@ $QEMU_IO -f qcow2 -c "write -P 0xb 10240 512" "$TEST_IMG.qcow2" | _filter_qemu_i > $QEMU_IMG convert -f qcow2 -O vmdk -o subformat=streamOptimized "$TEST_IMG.qcow2" "$TEST_IMG" 2>&1 > > echo > +echo "=== Testing monolithicFlat with internally generated JSON file name ===" > +IMGOPTS="subformat=monolithicFlat" _make_test_img 64M > +$QEMU_IO -c "open -o driver=$IMGFMT,file.driver=blkdebug,file.image.filename=$TEST_IMG,file.inject-error.0.event=read_aio" 2>&1 \ > + | _filter_testdir | _filter_imgfmt > + > +echo > echo "=== Testing version 3 ===" > _use_sample_img iotest-version3.vmdk.bz2 > _img_info > diff --git a/tests/qemu-iotests/059.out b/tests/qemu-iotests/059.out > index 0dadba6..97509ab 100644 > --- a/tests/qemu-iotests/059.out > +++ b/tests/qemu-iotests/059.out > @@ -2053,6 +2053,10 @@ wrote 512/512 bytes at offset 0 > wrote 512/512 bytes at offset 10240 > 512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > > +=== Testing monolithicFlat with internally generated JSON file name === > +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 > +qemu-io: can't open: Cannot use extents with VMDK descriptor file 'json:{"image": {"driver": "file", "filename": "TEST_DIR/t.IMGFMT"}, "driver": "blkdebug", "inject-error.0.event": "read_aio"}' > + > === Testing version 3 === > image: TEST_DIR/iotest-version3.IMGFMT > file format: IMGFMT > -- > 1.9.3 > Reviewed-by: Fam Zheng