From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752145AbaLDCFG (ORCPT ); Wed, 3 Dec 2014 21:05:06 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:55290 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbaLDCFD (ORCPT ); Wed, 3 Dec 2014 21:05:03 -0500 Date: Thu, 4 Dec 2014 11:04:49 +0900 From: Gyungoh Yoo To: Oliver Neukum Cc: sameo@linux.intel.com, lee.jones@linaro.org, grant.likely@linaro.org, robh+dt@kernel.org, jg1.han@samsung.com, cooloney@gmail.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, trivial@kernel.org, akpm@linux-foundation.org, jic23@kernel.org, thomas.petazzoni@free-electrons.com, ktsai@capellamicro.com, hs@denx.de, stwiss.opensource@diasemi.com, matti.vaittinen@nsn.com, broonie@kernel.org, jason@lakedaemon.net, heiko@sntech.de, shawn.guo@freescale.com, florian.vaussard@epfl.ch, andrew@lunn.ch, antonynpavlov@gmail.com, hytszk@gmail.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, jack.yoo@skyworksinc.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v10 2/6] backlight: Add support Skyworks SKY81452 backlight driver Message-ID: <20141204020449.GA2939@jack-ThinkPad-T520> References: <1417590332-4912-1-git-send-email-jack.yoo@skyworksinc.com> <1417590332-4912-3-git-send-email-jack.yoo@skyworksinc.com> <1417600949.12511.7.camel@linux-0dmf.site> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1417600949.12511.7.camel@linux-0dmf.site> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 03, 2014 at 11:02:29AM +0100, Oliver Neukum wrote: > On Wed, 2014-12-03 at 16:05 +0900, gyungoh@gmail.com wrote: > > +static ssize_t sky81452_bl_store_enable(struct device *dev, > > + struct device_attribute *attr, const char *buf, size_t > > count) > > +{ > > + struct regmap *regmap = bl_get_data(to_backlight_device(dev)); > > + unsigned long value; > > + int ret; > > + > > + ret = kstrtoul(buf, 16, &value); > > + if (IS_ERR_VALUE(ret)) > > + return ret; > > + > > + ret = regmap_update_bits(regmap, SKY81452_REG1, SKY81452_EN, > > + value << CTZ(SKY81452_EN)); > > No range checking for value? Avaiable range is from 0 to SKY81452_EN. regmap_update_bits() is masking the value. > > > + if (IS_ERR_VALUE(ret)) > > + return ret; > > + > > + return count; > > +} > > Regards > Oliver > > -- > Oliver Neukum > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gyungoh Yoo Subject: Re: [PATCH v10 2/6] backlight: Add support Skyworks SKY81452 backlight driver Date: Thu, 4 Dec 2014 11:04:49 +0900 Message-ID: <20141204020449.GA2939@jack-ThinkPad-T520> References: <1417590332-4912-1-git-send-email-jack.yoo@skyworksinc.com> <1417590332-4912-3-git-send-email-jack.yoo@skyworksinc.com> <1417600949.12511.7.camel@linux-0dmf.site> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1417600949.12511.7.camel-AfvqVibwNMkMNNZnWhT/Jw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Oliver Neukum Cc: sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, ktsai-GubuWUlQtMwciDkP5Hr2oA@public.gmane.org, hs-ynQEQJNshbs@public.gmane.org, stwiss.opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org, matti.vaittinen-OYasijW0DpE@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org, florian.vaussard-p8DiymsW2f8@public.gmane.org, andrew-g2DYL2Zd6BY@public.gmane.org, antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, hytszk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org, tomi.valkeinen-l0cyMroinI0@public.gmane.org, jack.yoo-tjhQNA90jdKqndwCJWfcng@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Dec 03, 2014 at 11:02:29AM +0100, Oliver Neukum wrote: > On Wed, 2014-12-03 at 16:05 +0900, gyungoh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > > +static ssize_t sky81452_bl_store_enable(struct device *dev, > > + struct device_attribute *attr, const char *buf, size_t > > count) > > +{ > > + struct regmap *regmap = bl_get_data(to_backlight_device(dev)); > > + unsigned long value; > > + int ret; > > + > > + ret = kstrtoul(buf, 16, &value); > > + if (IS_ERR_VALUE(ret)) > > + return ret; > > + > > + ret = regmap_update_bits(regmap, SKY81452_REG1, SKY81452_EN, > > + value << CTZ(SKY81452_EN)); > > No range checking for value? Avaiable range is from 0 to SKY81452_EN. regmap_update_bits() is masking the value. > > > + if (IS_ERR_VALUE(ret)) > > + return ret; > > + > > + return count; > > +} > > Regards > Oliver > > -- > Oliver Neukum > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gyungoh Yoo Date: Thu, 04 Dec 2014 02:04:49 +0000 Subject: Re: [PATCH v10 2/6] backlight: Add support Skyworks SKY81452 backlight driver Message-Id: <20141204020449.GA2939@jack-ThinkPad-T520> List-Id: References: <1417590332-4912-1-git-send-email-jack.yoo@skyworksinc.com> <1417590332-4912-3-git-send-email-jack.yoo@skyworksinc.com> <1417600949.12511.7.camel@linux-0dmf.site> In-Reply-To: <1417600949.12511.7.camel-AfvqVibwNMkMNNZnWhT/Jw@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Oliver Neukum Cc: sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, ktsai-GubuWUlQtMwciDkP5Hr2oA@public.gmane.org, hs-ynQEQJNshbs@public.gmane.org, stwiss.opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org, matti.vaittinen-OYasijW0DpE@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org, florian.vaussard-p8DiymsW2f8@public.gmane.org, andrew-g2DYL2Zd6BY@public.gmane.org, antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, hytszk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org, tomi.valkeinen-l0cyMroinI0@public.gmane.org, jack.yoo-tjhQNA90jdKqndwCJWfcng@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Wed, Dec 03, 2014 at 11:02:29AM +0100, Oliver Neukum wrote: > On Wed, 2014-12-03 at 16:05 +0900, gyungoh@gmail.com wrote: > > +static ssize_t sky81452_bl_store_enable(struct device *dev, > > + struct device_attribute *attr, const char *buf, size_t > > count) > > +{ > > + struct regmap *regmap = bl_get_data(to_backlight_device(dev)); > > + unsigned long value; > > + int ret; > > + > > + ret = kstrtoul(buf, 16, &value); > > + if (IS_ERR_VALUE(ret)) > > + return ret; > > + > > + ret = regmap_update_bits(regmap, SKY81452_REG1, SKY81452_EN, > > + value << CTZ(SKY81452_EN)); > > No range checking for value? Avaiable range is from 0 to SKY81452_EN. regmap_update_bits() is masking the value. > > > + if (IS_ERR_VALUE(ret)) > > + return ret; > > + > > + return count; > > +} > > Regards > Oliver > > -- > Oliver Neukum >