From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933586AbaLECb0 (ORCPT ); Thu, 4 Dec 2014 21:31:26 -0500 Received: from mail-pd0-f177.google.com ([209.85.192.177]:61595 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932378AbaLECbX (ORCPT ); Thu, 4 Dec 2014 21:31:23 -0500 Date: Thu, 4 Dec 2014 18:31:19 -0800 From: Brian Norris To: Scott Branden Cc: David Woodhouse , Ray Jui , Corneliu Doban , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: add reboot notifier to mtdcore and register nand_shutdown with notifier Message-ID: <20141205023119.GM21347@ld-irv-0074> References: <1417732658-4563-1-git-send-email-sbranden@broadcom.com> <5480F88D.4090707@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5480F88D.4090707@broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 04, 2014 at 04:13:01PM -0800, Scott Branden wrote: > Apologies: patch fails checkpatch due to spaces instead of tabs > during cut and paste. > > But, please comment on this patch before I create a new version. I'd prefer the separation to be as I sent in the first place; one patch to add a generic hook for all MTD's, and one to implement the hook in NAND. I can just resend my patch (fixed up to compile correctly; I had an error previously), then you can just add your Tested-by. Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pd0-x22a.google.com ([2607:f8b0:400e:c02::22a]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XwigK-0002eI-Db for linux-mtd@lists.infradead.org; Fri, 05 Dec 2014 02:31:45 +0000 Received: by mail-pd0-f170.google.com with SMTP id v10so3772070pde.15 for ; Thu, 04 Dec 2014 18:31:22 -0800 (PST) Date: Thu, 4 Dec 2014 18:31:19 -0800 From: Brian Norris To: Scott Branden Subject: Re: [PATCH] mtd: add reboot notifier to mtdcore and register nand_shutdown with notifier Message-ID: <20141205023119.GM21347@ld-irv-0074> References: <1417732658-4563-1-git-send-email-sbranden@broadcom.com> <5480F88D.4090707@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5480F88D.4090707@broadcom.com> Cc: Corneliu Doban , Ray Jui , David Woodhouse , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Dec 04, 2014 at 04:13:01PM -0800, Scott Branden wrote: > Apologies: patch fails checkpatch due to spaces instead of tabs > during cut and paste. > > But, please comment on this patch before I create a new version. I'd prefer the separation to be as I sent in the first place; one patch to add a generic hook for all MTD's, and one to implement the hook in NAND. I can just resend my patch (fixed up to compile correctly; I had an error previously), then you can just add your Tested-by. Brian