From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm/i915: Reorder hw init to avoid executing with invalid context/mm state Date: Fri, 5 Dec 2014 16:31:35 +0200 Message-ID: <20141205143135.GL10649@intel.com> References: <1417788922-1564-1-git-send-email-chris@chris-wilson.co.uk> <1417788922-1564-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 61F296E9CD for ; Fri, 5 Dec 2014 06:31:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <1417788922-1564-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBEZWMgMDUsIDIwMTQgYXQgMDI6MTU6MjJQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IEN1cnJlbnRseSB3ZSBpbml0aWFsaXNlIHRoZSByaW5ncywgYWRkIHRoZSBmaXJzdCBj b250ZXh0IHN3aXRjaCB0byB0aGUKPiByaW5nIGFuZCBleGVjdXRlIG91ciBnb2xkZW4gc3RhdGUg dGhlbiBlbmFibGUgKGFsaWFzaW5nIG9yIGZ1bGwpIHBwZ3R0Lgo+IEhvd2V2ZXIsIGFzIHdlIGVu YWJsZSBwcGd0dCB1c2luZyBkaXJlY3QgTU1JTyBidXQgbG9hZCB0aGUgUEQgdXNpbmcKPiBNSV9M UkksIHdlIGVuZCB1cCBleGVjdXRpbmcgdGhlIGNvbnRleHQgc3dpdGNoIGFuZCBnb2xkZW4gcmVu ZGVyIHN0YXRlCj4gd2l0aCBhbiBpbnZhbGlkIFBEIGdlbmVyYXRpbmcgcGFnZSBmYXVsdHMuIFRv IHNvbHZlIHRoaXMgaXNzdWUsIGZpcnN0IGRvCj4gdGhlIHBwZ3R0IFBEIHNldHVwLCB0aGVuIHNl dCB0aGUgZGVmYXVsdCBjb250ZXh0IGFuZCB3cml0ZSB0aGUgY29tbWFuZHMKPiB0byBydW4gdGhl IHJlbmRlciBzdGF0ZSBpbnRvIHRoZSByaW5nLCBiZWZvcmUgd2UgYWN0aXZhdGUgdGhlIHJpbmcu IFRoaXMKPiBhbGxvd3MgdXMgdG8gYmUgc3VyZSB0aGF0IHRoZSByZWdpc3RlciBzdGF0ZSBpcyB2 YWxpZCBiZWZvcmUgd2UgYmVnaW4KPiBleGVjdXRpb24uCj4gCj4gVGhpcyB3YXMgc3BvdHRlZCB3 aGVuIHdyaXRpbmcgdGhlIHNlcW5vL3JlcXVlc3QgY29udmVyc2lvbiwgYnV0IG9ubHkgd2l0aAo+ IHRoZSBFUlJPUiBjYXB0dXJlIGRpZCBJIHJlYWxpc2UgdGhhdCBpdCB3YXMgYSBuZWNlc3NpdHkg bm93Lgo+IAo+IFJGQzogY2xlYW51cCB0aGUgZXJyb3IgaGFuZGxpbmcgaW4gaTkxNV9nZW1faW5p dF9ody4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNv bi5jby51az4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgICAgICAg IHwgMjAgKysrKysrKysrKy0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cmluZ2J1ZmZlci5jIHwgIDkgKysrKysrLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0 aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5k ZXggYzFjMTE0MTgyMzFiLi5jMTM4NDJkM2NiYzkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMKPiBAQCAtNDc5NiwxNSArNDc5NiwxNSBAQCBpOTE1X2dlbV9pbml0X2h3KHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYpCj4gIAkgKi8KPiAgCWluaXRfdW51c2VkX3JpbmdzKGRldik7Cj4gIAo+IC0J Zm9yX2VhY2hfcmluZyhyaW5nLCBkZXZfcHJpdiwgaSkgewo+IC0JCXJldCA9IHJpbmctPmluaXRf aHcocmluZyk7Cj4gLQkJaWYgKHJldCkKPiAtCQkJcmV0dXJuIHJldDsKPiAtCX0KPiAtCj4gIAlm b3IgKGkgPSAwOyBpIDwgTlVNX0wzX1NMSUNFUyhkZXYpOyBpKyspCj4gIAkJaTkxNV9nZW1fbDNf cmVtYXAoJmRldl9wcml2LT5yaW5nW1JDU10sIGkpOwoKVGhpcyBpcyBnb2luZyB0byBhc3N1bWUg cmluZy0+aGVhZC90YWlsIGFyZSBhbHJlYWR5IHZhbGlkPwoKPiAgCj4gKwlyZXQgPSBpOTE1X3Bw Z3R0X2luaXRfaHcoZGV2KTsKPiArCWlmIChyZXQgJiYgcmV0ICE9IC1FSU8pIHsKPiArCQlEUk1f RVJST1IoIlBQR1RUIGVuYWJsZSBmYWlsZWQgJWRcbiIsIHJldCk7Cj4gKwkJaTkxNV9nZW1fY2xl YW51cF9yaW5nYnVmZmVyKGRldik7Cj4gKwl9Cj4gKwo+ICAJLyoKPiAgCSAqIFhYWDogQ29udGV4 dHMgc2hvdWxkIG9ubHkgYmUgaW5pdGlhbGl6ZWQgb25jZS4gRG9pbmcgYSBzd2l0Y2ggdG8gdGhl Cj4gIAkgKiBkZWZhdWx0IGNvbnRleHQgc3dpdGNoIGhvd2V2ZXIgaXMgc29tZXRoaW5nIHdlJ2Qg bGlrZSB0byBkbyBhZnRlcgo+IEBAIC00ODIwLDEwICs0ODIwLDEwIEBAIGk5MTVfZ2VtX2luaXRf aHcoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCQlyZXR1cm4gcmV0Owo+ICAJfQo+ICAKPiAt CXJldCA9IGk5MTVfcHBndHRfaW5pdF9odyhkZXYpOwo+IC0JaWYgKHJldCAmJiByZXQgIT0gLUVJ Tykgewo+IC0JCURSTV9FUlJPUigiUFBHVFQgZW5hYmxlIGZhaWxlZCAlZFxuIiwgcmV0KTsKPiAt CQlpOTE1X2dlbV9jbGVhbnVwX3JpbmdidWZmZXIoZGV2KTsKPiArCWZvcl9lYWNoX3Jpbmcocmlu ZywgZGV2X3ByaXYsIGkpIHsKPiArCQlyZXQgPSByaW5nLT5pbml0X2h3KHJpbmcpOwo+ICsJCWlm IChyZXQpCj4gKwkJCXJldHVybiByZXQ7Cj4gIAl9Cj4gIAo+ICAJcmV0dXJuIHJldDsKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gaW5kZXggZGUzOGIwNDEzNWQyLi45 NWViY2U3M2Q0NmQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmlu Z2J1ZmZlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5j Cj4gQEAgLTU4NSw2ICs1ODUsOSBAQCBzdGF0aWMgaW50IGluaXRfcmluZ19jb21tb24oc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqcmluZykKPiAgCUk5MTVfV1JJVEVfSEVBRChyaW5nLCAwKTsKPiAg CSh2b2lkKUk5MTVfUkVBRF9IRUFEKHJpbmcpOwo+ICAKPiArCUk5MTVfV1JJVEVfSEVBRChyaW5n LCByaW5nYnVmLT5oZWFkKTsKPiArCUk5MTVfV1JJVEVfVEFJTChyaW5nLCByaW5nYnVmLT5oZWFk KTsKCkhlcmUgdG9vLgoKU28gd2hhdCBoYXBwZW5zIG9uIEdQVSByZXNldD8KCj4gKwo+ICAJSTkx NV9XUklURV9DVEwocmluZywKPiAgCQkJKChyaW5nYnVmLT5zaXplIC0gUEFHRV9TSVpFKSAmIFJJ TkdfTlJfUEFHRVMpCj4gIAkJCXwgUklOR19WQUxJRCk7Cj4gQEAgLTU5Miw3ICs1OTUsNyBAQCBz dGF0aWMgaW50IGluaXRfcmluZ19jb21tb24oc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZykK PiAgCS8qIElmIHRoZSBoZWFkIGlzIHN0aWxsIG5vdCB6ZXJvLCB0aGUgcmluZyBpcyBkZWFkICov Cj4gIAlpZiAod2FpdF9mb3IoKEk5MTVfUkVBRF9DVEwocmluZykgJiBSSU5HX1ZBTElEKSAhPSAw ICYmCj4gIAkJICAgICBJOTE1X1JFQURfU1RBUlQocmluZykgPT0gaTkxNV9nZW1fb2JqX2dndHRf b2Zmc2V0KG9iaikgJiYKPiAtCQkgICAgIChJOTE1X1JFQURfSEVBRChyaW5nKSAmIEhFQURfQURE UikgPT0gMCwgNTApKSB7Cj4gKwkJICAgICAoSTkxNV9SRUFEX0hFQUQocmluZykgJiBIRUFEX0FE RFIpID09IHJpbmdidWYtPmhlYWQsIDUwKSkgewo+ICAJCURSTV9FUlJPUigiJXMgaW5pdGlhbGl6 YXRpb24gZmFpbGVkICIKPiAgCQkJICAiY3RsICUwOHggKHZhbGlkPyAlZCkgaGVhZCAlMDh4IHRh aWwgJTA4eCBzdGFydCAlMDh4IFtleHBlY3RlZCAlMDhseF1cbiIsCj4gIAkJCSAgcmluZy0+bmFt ZSwKPiBAQCAtNjAzLDkgKzYwNiw5IEBAIHN0YXRpYyBpbnQgaW5pdF9yaW5nX2NvbW1vbihzdHJ1 Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQo+ICAJCWdvdG8gb3V0Owo+ICAJfQo+ICAKPiArCUk5 MTVfV1JJVEVfVEFJTChyaW5nLCByaW5nYnVmLT50YWlsKTsKPiArCj4gIAlyaW5nYnVmLT5sYXN0 X3JldGlyZWRfaGVhZCA9IC0xOwo+IC0JcmluZ2J1Zi0+aGVhZCA9IEk5MTVfUkVBRF9IRUFEKHJp bmcpOwo+IC0JcmluZ2J1Zi0+dGFpbCA9IEk5MTVfUkVBRF9UQUlMKHJpbmcpICYgVEFJTF9BRERS Owo+ICAJaW50ZWxfcmluZ191cGRhdGVfc3BhY2UocmluZ2J1Zik7Cj4gIAo+ICAJbWVtc2V0KCZy aW5nLT5oYW5nY2hlY2ssIDAsIHNpemVvZihyaW5nLT5oYW5nY2hlY2spKTsKPiAtLSAKPiAyLjEu Mwo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=