From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755866AbaLHQCu (ORCPT ); Mon, 8 Dec 2014 11:02:50 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:60376 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752358AbaLHQCt (ORCPT ); Mon, 8 Dec 2014 11:02:49 -0500 Date: Mon, 8 Dec 2014 11:02:40 -0500 From: Johannes Weiner To: Rickard Strandqvist Cc: Michal Hocko , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol.c: Cleaning up function that are not used anywhere Message-ID: <20141208160240.GA21664@phnom.home.cmpxchg.org> References: <1417884356-3086-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417884356-3086-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 06, 2014 at 05:45:56PM +0100, Rickard Strandqvist wrote: > Remove function mem_cgroup_lru_names_not_uptodate() that is not used anywhere. > And move BUILD_BUG_ON() to the beginning of memcg_stat_show() instead. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist Looks good, thanks for following up. Acked-by: Johannes Weiner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by kanga.kvack.org (Postfix) with ESMTP id CD7C96B0038 for ; Mon, 8 Dec 2014 11:02:54 -0500 (EST) Received: by mail-pa0-f41.google.com with SMTP id rd3so5457532pab.14 for ; Mon, 08 Dec 2014 08:02:54 -0800 (PST) Received: from gum.cmpxchg.org (gum.cmpxchg.org. [85.214.110.215]) by mx.google.com with ESMTPS id cu3si60519489pbc.108.2014.12.08.08.02.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Dec 2014 08:02:53 -0800 (PST) Date: Mon, 8 Dec 2014 11:02:40 -0500 From: Johannes Weiner Subject: Re: [PATCH] mm: memcontrol.c: Cleaning up function that are not used anywhere Message-ID: <20141208160240.GA21664@phnom.home.cmpxchg.org> References: <1417884356-3086-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417884356-3086-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Sender: owner-linux-mm@kvack.org List-ID: To: Rickard Strandqvist Cc: Michal Hocko , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Sat, Dec 06, 2014 at 05:45:56PM +0100, Rickard Strandqvist wrote: > Remove function mem_cgroup_lru_names_not_uptodate() that is not used anywhere. > And move BUILD_BUG_ON() to the beginning of memcg_stat_show() instead. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist Looks good, thanks for following up. Acked-by: Johannes Weiner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH] mm: memcontrol.c: Cleaning up function that are not used anywhere Date: Mon, 8 Dec 2014 11:02:40 -0500 Message-ID: <20141208160240.GA21664@phnom.home.cmpxchg.org> References: <1417884356-3086-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1417884356-3086-1-git-send-email-rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Rickard Strandqvist Cc: Michal Hocko , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Sat, Dec 06, 2014 at 05:45:56PM +0100, Rickard Strandqvist wrote: > Remove function mem_cgroup_lru_names_not_uptodate() that is not used anywhere. > And move BUILD_BUG_ON() to the beginning of memcg_stat_show() instead. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist Looks good, thanks for following up. Acked-by: Johannes Weiner