From: Dave Chinner <david@fromorbit.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>,
fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4/004: add dump/restore test
Date: Tue, 16 Dec 2014 14:59:43 +1100 [thread overview]
Message-ID: <20141216035942.GE2152@dastard> (raw)
In-Reply-To: <20141216025827.GO17575@thunk.org>
On Mon, Dec 15, 2014 at 09:58:27PM -0500, Theodore Ts'o wrote:
> On Mon, Dec 08, 2014 at 09:44:48AM +0800, Xiaoguang Wang wrote:
> >
> > Yeah, my intent is to test dump/restore program, and indeed I imitate that
> > how xfs to test xfsdump/xfsrestore, xfs puts xfsdump/xfsrestore tests in
> > corresponding xfs directory.
>
> I'm finding that the test takes 6-7 minutes to run, partially because
> it's writing close to half a gigabyte worth of data for the
> dump/restore. Is this really necessary? Can we perhaps cut down the
> amount of data generated by running fsstress?
Yes, that is too long for an "auto" test. A couple of minutes is
about the limit we should be trying to stick to for auto tests; we
don't really add any extra coverage by making such tests run for a
long time.
As it is, most of the xfsdump/restore tests take around 30-60s to
run, so that's probably a good guide to follow for this.
> And I'll note that using the current fsstress arguments, you are only
> creating regular files and directories, and there are no symlinks,
> device nodes, or FIFO's being created to test whether those files are
> correctly being backed up and restored.
Probably a good idea, too. Thanks for looking at this, Ted.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2014-12-16 3:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 10:21 [PATCH] ext4/004: add dump/restore test Xiaoguang Wang
2014-11-25 10:21 ` Xiaoguang Wang
2014-12-01 5:45 ` Dave Chinner
2014-12-03 2:44 ` Xiaoguang Wang
2014-12-03 2:44 ` Xiaoguang Wang
2014-12-03 6:40 ` [PATCH v2] " Xiaoguang Wang
2014-12-03 6:40 ` Xiaoguang Wang
2014-12-03 7:49 ` Eryu Guan
2014-12-03 9:47 ` Xiaoguang Wang
2014-12-03 9:47 ` Xiaoguang Wang
2014-12-04 7:29 ` Eryu Guan
2014-12-05 7:16 ` [PATCH v3] ext4: " Xiaoguang Wang
2014-12-05 7:16 ` Xiaoguang Wang
2014-12-06 21:40 ` [PATCH] ext4/004: " Theodore Ts'o
2014-12-06 23:44 ` Dave Chinner
2014-12-08 1:44 ` Xiaoguang Wang
2014-12-08 1:44 ` Xiaoguang Wang
2014-12-16 2:58 ` Theodore Ts'o
2014-12-16 3:59 ` Dave Chinner [this message]
2014-12-16 15:53 ` Theodore Ts'o
2014-12-16 19:36 ` Dave Chinner
2014-12-17 5:16 ` Xiaoguang Wang
2014-12-17 5:16 ` Xiaoguang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216035942.GE2152@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.