From: Ralf Baechle <ralf@linux-mips.org>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: JZ4740: fixup #include's (sparse)
Date: Thu, 18 Dec 2014 14:02:03 +0100 [thread overview]
Message-ID: <20141218130203.GC25711@linux-mips.org> (raw)
In-Reply-To: <1418870341-16618-1-git-send-email-computersforpeace@gmail.com>
On Wed, Dec 17, 2014 at 06:39:01PM -0800, Brian Norris wrote:
> Fixes sparse warnings:
>
> arch/mips/jz4740/irq.c:63:6: warning: symbol 'jz4740_irq_suspend' was not declared. Should it be static?
> arch/mips/jz4740/irq.c:69:6: warning: symbol 'jz4740_irq_resume' was not declared. Should it be static?
>
> Also, I've seen some elusive build errors on my automated build test
> where JZ4740_IRQ_BASE and NR_IRQS are missing, but I can't reproduce
> them manually for some reason. Anyway, mach-jz4740/irq.h should help us
> avoid relying on some implicit include.
Patch is looking good.
There is a known issue building jz in a separate build directory; building
in the source directory itself will succeed. Could that be why you can't
seem to reproduce the build issue?
Ralf
next prev parent reply other threads:[~2014-12-18 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 2:39 [PATCH] MIPS: JZ4740: fixup #include's (sparse) Brian Norris
2014-12-18 13:02 ` Ralf Baechle [this message]
2014-12-18 14:44 ` Ralf Baechle
2014-12-18 17:22 ` Brian Norris
2014-12-18 17:15 ` Brian Norris
2014-12-18 15:29 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141218130203.GC25711@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=computersforpeace@gmail.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.