From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH v3 1/2] acpi: Add "acpi_osi=" for ASUS X200MA to enable, brightness keys Date: Thu, 18 Dec 2014 13:27:53 +0000 Message-ID: <20141218132753.GA4918@srcf.ucam.org> References: <5492C5A3.8090700@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org To: Josh Boyer Cc: Dmitry Tunin , "linux-acpi@vger.kernel.org" , linux-kernel , "stable@vger.kernel.org" , Aaron Lu List-Id: linux-acpi@vger.kernel.org On Thu, Dec 18, 2014 at 08:25:42AM -0500, Josh Boyer wrote: > What does this do to the rest of the function keys? Does everything > else still work as expected, including suspend and resume? Disabling OSI completely certainly runs the risk of turning off things like HPET. It certainly shouldn't be done without checking the ACPI tables, and it really shouldn't be done at all because this is Intel's bug and they should just fix it. -- Matthew Garrett | mjg59@srcf.ucam.org