From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932176AbaLWMdd (ORCPT ); Tue, 23 Dec 2014 07:33:33 -0500 Received: from mail-wg0-f45.google.com ([74.125.82.45]:44967 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753681AbaLWMdc (ORCPT ); Tue, 23 Dec 2014 07:33:32 -0500 Date: Tue, 23 Dec 2014 13:33:28 +0100 From: Dongsu Park To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, Jens Axboe , Kent Overstreet , Ming Lin , Al Viro , linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [RFC PATCH 16/17] fs: convert buffer head etc. to use immutable biovecs API. Message-ID: <20141223123328.GH15080@gmail.com> References: <4287748e7d1a0fce1c951567a7688821f1a21e5e.1419241597.git.dongsu.park@profitbricks.com> <20141223105128.GE27600@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20141223105128.GE27600@infradead.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.12.2014 02:51, Christoph Hellwig wrote: > On Mon, Dec 22, 2014 at 12:48:43PM +0100, Dongsu Park wrote: > > From: Kent Overstreet > > > > Increase bio->bi_remaining instead of calling bio_get(), > > and call bio_end() instead of bio_put() upon buffer_head submission. > > Nees an explanation on why this is done. Right. > > Also make bio submission in kernel/power/block_io.c to properly submit > > bios by checking whether bio_chain is available or not. > > Should be a separate patch. > > And of course both should go into the preparation series of cleanups. Yep, agreed. I'll split it up and also move them to the prep series. Thanks, Dongsu