All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH 0/7] Move EAL common functions
Date: Mon, 29 Dec 2014 07:47:23 -0500	[thread overview]
Message-ID: <20141229124723.GA27775@localhost.localdomain> (raw)
In-Reply-To: <54A11509.5050904-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

On Mon, Dec 29, 2014 at 09:47:05AM +0100, Olivier MATZ wrote:
> Hi Ravi,
> 
> On 12/25/2014 04:33 PM, Ravi Kerur wrote:
> > Common functions in linuxapp and bsdapp are moved into
> > librte_eal/common directory.
> > New files added follow _common_ naming conventions.
> > Tested against ubuntu and FreeBSD.
> 
> Trying to factorize the common code goes in the good direction.
> 
> However I'm wondering if "common" is the proper place. Initially,
> the common directory was for code common to linuxapp and baremetal.
> Now that baremetal does not exist anymore, a lot of code is common
> to the 2 OSes that are supported (linux and FreeBSD).
> 
> What about moving this code in "common-posix" instead?
> It would let the door open for future ports (Windows? or any
> other real time OS? Or back in baremetal?).
> 
Posix doesn't make sense IMO, in that a large segment of the functions embodied
in the common directory have nothing to do with posix API's, and are simply just
useful functions that have not OS specific dependency (the entire
eal_common_memory.c file for example, to name just one).  

If you wanted to rename the directory, I would say generic-os would be more
appropriate.

Neil

> Regards,
> Olivier
> 

  parent reply	other threads:[~2014-12-29 12:47 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-25 15:33 [PATCH 0/7] Move EAL common functions Ravi Kerur
     [not found] ` <1419521597-31978-1-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-25 15:33   ` [PATCH 1/7] Fix rte_is_power_of_2 Ravi Kerur
     [not found]     ` <1419521597-31978-2-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-25 17:21       ` Neil Horman
     [not found]         ` <20141225172144.GC3199-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-12-25 18:54           ` Ravi Kerur
2014-12-25 15:33   ` [PATCH 2/7] Move EAL common functions Ravi Kerur
     [not found]     ` <1419521597-31978-3-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-25 17:30       ` Neil Horman
     [not found]         ` <20141225173041.GD3199-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-12-25 19:23           ` Ravi Kerur
     [not found]             ` <CAFb4SLB3TQ6odVJkm85Vt7oQ=ZHW23RtyQo_8t+HpjhSVrFHeg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-26 14:40               ` Neil Horman
     [not found]                 ` <20141226144000.GC5567-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-12-26 15:28                   ` Ravi Kerur
     [not found]                     ` <CAFb4SLCioyA2BXy4bHOeEh=ssjz0xb=FEV+JZ4fBp4PDz6ufrw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-05  9:40                       ` Thomas Monjalon
2014-12-25 15:33   ` [PATCH 3/7] " Ravi Kerur
     [not found]     ` <1419521597-31978-4-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-25 17:41       ` Neil Horman
     [not found]         ` <20141225174146.GE3199-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-12-25 19:13           ` Ravi Kerur
     [not found]             ` <CAFb4SLCP_bN=hDC-8H0BN+VnSr51ozfz2=jH3aU_Pe=b9t2v2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-26 14:40               ` Neil Horman
2014-12-25 15:33   ` [PATCH 4/7] " Ravi Kerur
     [not found]     ` <1419521597-31978-5-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-25 17:44       ` Neil Horman
     [not found]         ` <20141225174418.GF3199-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-12-25 19:17           ` Ravi Kerur
     [not found]             ` <CAFb4SLAkQde6=ShBqKT-p6QGQZHkYFgHC4Q0af+g5CfwJJrQ4w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-26 14:42               ` Neil Horman
     [not found]                 ` <20141226144221.GE5567-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-12-26 15:30                   ` Ravi Kerur
2015-01-05 15:59       ` Thomas Monjalon
2015-01-05 16:21         ` Ravi Kerur
2015-01-05 18:56         ` Ravi Kerur
     [not found]           ` <CAFb4SLAr=_28qSe9ss7G2iS=fcKi00TmyGR1vQiSBWDek1A3Og-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-05 20:38             ` Thomas Monjalon
2015-01-06 17:35               ` Ravi Kerur
2014-12-25 15:33   ` [PATCH 5/7] " Ravi Kerur
     [not found]     ` <1419521597-31978-6-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-05 15:32       ` Thomas Monjalon
2014-12-25 15:33   ` [PATCH 6/7] " Ravi Kerur
     [not found]     ` <1419521597-31978-7-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-05 15:49       ` Thomas Monjalon
2014-12-25 15:33   ` [PATCH 7/7] " Ravi Kerur
     [not found]     ` <1419521597-31978-8-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-25 17:46       ` Neil Horman
     [not found]         ` <20141225174649.GG3199-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-12-25 19:22           ` Ravi Kerur
     [not found]             ` <CAFb4SLCVHWoihgBY7POThqvT4dbMsLbWebTseftV7OcfjHKprQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-26 14:44               ` Neil Horman
     [not found]                 ` <20141226144428.GF5567-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-12-26 15:28                   ` Ravi Kerur
2014-12-29  8:47   ` [PATCH 0/7] " Olivier MATZ
     [not found]     ` <54A11509.5050904-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-12-29 12:47       ` Neil Horman [this message]
     [not found]         ` <20141229124723.GA27775-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-12-29 13:16           ` Olivier MATZ
     [not found]             ` <54A15420.2010401-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-12-29 16:17               ` Neil Horman
2014-12-29 18:43               ` Ravi Kerur
     [not found]                 ` <CAFb4SLA2G-_=9KRefBO9nV-PJDFr6bvz8-JUEH-8F+MAuEXn3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-04 23:10                   ` Ravi Kerur
     [not found]                     ` <CAFb4SLA28vy1BHs0O7NMAPEFyEHG_aRxEkpv0EiLeLAD53zQmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-05 12:24                       ` Bruce Richardson
2015-01-09  9:50                         ` Olivier MATZ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141229124723.GA27775@localhost.localdomain \
    --to=nhorman-2xusbdqka4r54taoqtywwq@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.