From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753278AbbAEG7I (ORCPT ); Mon, 5 Jan 2015 01:59:08 -0500 Received: from smtp.mei.co.jp ([133.183.100.20]:33788 "EHLO smtp.mei.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121AbbAEG7H (ORCPT ); Mon, 5 Jan 2015 01:59:07 -0500 Date: Mon, 05 Jan 2015 15:58:46 +0900 From: Masahiro Yamada To: Michal Marek Subject: Re: [PATCH 1/2] kbuild: merge bounds.h and asm-offsets.h rules Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <54A6C19A.3080001@suse.cz> References: <1419403765-3377-2-git-send-email-yamada.m@jp.panasonic.com> <54A6C19A.3080001@suse.cz> X-BkSecure-Plugin: BkSecure.dll Ver 1, 2, 7, 0 Message-Id: <20150105155846.B978.AA925319@jp.panasonic.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.64.06 [ja] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, On Fri, 02 Jan 2015 17:04:42 +0100 Michal Marek wrote: > > > > -quiet_cmd_bounds = GEN $@ > > -define cmd_bounds > > +quiet_cmd_offsets = GEN $@ > > +define cmd_offsets > > (set -e; \ > > - echo "#ifndef __LINUX_BOUNDS_H__"; \ > > - echo "#define __LINUX_BOUNDS_H__"; \ > > + INCLUDE_GUARD=$$(echo __$(notdir $@)__ | tr '[a-z].-' '[A-Z]__'); \ > > + echo "#ifndef $$INCLUDE_GUARD"; \ > > + echo "#define $$INCLUDE_GUARD"; \ > > I think it would be more readable to write it as > > echo "#ifndef $(2)"; \ > ... > > and pass the include guard name as an argument to cmd_offsets. > > Otherwise it's a great cleanup. > > Michal OK. I have posted v2. Best Regards Masahiro Yamada