From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8UiP-0004Ip-SG for qemu-devel@nongnu.org; Tue, 06 Jan 2015 09:02:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8UiL-0006l7-EC for qemu-devel@nongnu.org; Tue, 06 Jan 2015 09:02:33 -0500 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:52578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8UiL-0006kz-7R for qemu-devel@nongnu.org; Tue, 06 Jan 2015 09:02:29 -0500 Received: by mail-wi0-f175.google.com with SMTP id l15so5388297wiw.14 for ; Tue, 06 Jan 2015 06:02:28 -0800 (PST) Date: Tue, 6 Jan 2015 14:02:24 +0000 From: Stefan Hajnoczi Message-ID: <20150106140224.GK29775@stefanha-thinkpad.redhat.com> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4wkndigzIeYF6Hbg" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v4] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid Cc: Peter Maydell , qemu-devel qemu-devel --4wkndigzIeYF6Hbg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 02, 2015 at 04:44:38PM -0500, Programmingkid wrote: > Removes redundant ret variable and renames sectorSize variable to meet QE= MU coding standards.=20 This is a changelog item for v4 of this patch. Changelogs should go below the '---' line so they are not merged into git history. The rationale is that when a patch is merged into git, the changelog describing patch revisions that were posted on the mailing list is not relevant (we only see the final patch in git, not the revisions from the mailing list). Patches usually look like this: Subject: block/raw-posix: brief summary A longer description of the problem, maybe a command-line to reproduce a bug, and some rationale for this code change. Signed-off-by: Me --- v2: * Fix int -> size_t for memory lengths [Requested by Bob] The changelog at the bottom is useful to code reviewers but won't get merged in the git history. Anyway, thanks for this patch. I have dropped this changelog line and merged it! >=20 > Signed-off-by: John Arbuckle >=20 > --- > block/raw-posix.c | 18 +++++++++++++++++- > configure | 2 +- > 2 files changed, 18 insertions(+), 2 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --4wkndigzIeYF6Hbg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUq+rwAAoJEJykq7OBq3PIYKIIAMSL+6uUpgudh40NdisvEsrZ /N315hld7DzvdS4BLy4Xbvlasl0Q8tsa8OFAaLIgQkXJj9nC15BS8tfMk0iBRqvx ahZZckPJqyWV4Us9lJc0zlQpgErXQxJhuoYsUvqPt3vX+Cczb4NsMr74bZRcuGIF v/lji1CjAtxgnp4bd3vvJfECUwRvxHmiJxpnuHW7dM1CDzmbBnc7VeRVSE2ZxCSN AkNxX6ftspIpa9RLTfB2L3YiCMj/I3lpvu/NaoKPSIfTG+tBMGj+gxvHwvl+nvjC UE0GAcUBuPGTJk0r4geenvCwEuJQYsGTxRztyVsfGX7DQ0tZthGmthKLb4b8BDU= =iug4 -----END PGP SIGNATURE----- --4wkndigzIeYF6Hbg--