From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 0/7 v3] tools/hotplug: systemd changes for 4.5 Date: Tue, 6 Jan 2015 10:19:20 -0500 Message-ID: <20150106151920.GA8269@l.oracle.com> References: <1418988333-5404-1-git-send-email-olaf@aepfle.de> <20141219191032.GB9213@laptop.dumpdata.com> <20141222080639.GA6139@aepfle.de> <20141231153106.GA2928@laptop.dumpdata.com> <20150105212206.GA3869@l.oracle.com> <21675.63616.609314.279161@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <21675.63616.609314.279161@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Olaf Hering , wei.liu2@citrix.com, ian.campbell@citrix.com, mcgrof@do-not-panic.com, xen-devel@lists.xen.org, m.a.young@durham.ac.uk, anthony.perard@citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, Jan 06, 2015 at 03:00:16PM +0000, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH 0/7 v3] tools/hotplug: systemd changes for 4.5"): > > #4 ("tools/hotplug: use xencommons as EnvironmentFile in xenconsoled.service") > > #5 ("tools/hotplug: use XENCONSOLED_TRACE in xenconsoled.service") > > #6 ("tools/hotplug: remove EnvironmentFile from xen-qemu-dom0-disk-backend.service") > > > > need Acks. > > Done. Thank you. Let me apply #1-#6 in staging then. > > > For patch #1 ("tools/hotplug: remove SELinux options from var-lib-xenstored.mount") > > > > Release-Acked-by: Konrad Rzeszutek Wilk > > Tested-by: Konrad Rzeszutek Wilk > > > > with the below change to README file. It also needs an Ack. > > Done. > > > For patch #7 (" tools/hotplug: add wrapper to start xenstored") > > > > Tested-by: Konrad Rzeszutek Wilk > > However there is a question in there for Ian: > > > > "The place of the wrapper is currently LIBEXEC_BIN, it has to be > > decided what the final location is supposed to be. IanJ wants it in > > "/etc". > > " > > > > IanJ - any specific reasons for having it in /etc instead of > > LIBEXEC_BIN? This is in regards to the introduction of this file: > > I explained this in my previous response and made what I thought was > an unequivocal declaration about the location of the file. > > > Such as this might be good (Or perhaps move it to the INSTALL file) > ... > > --- a/README > > +++ b/README > ... > > +Release Issues > > +============== > > I'm happy to have this particular issue here in the README. > > But I think the release notes need to be out of tree. This is so that > if we discover an issue between last commit deadline and release, we > can update the release notes. Will create one on the Wiki and add it there. > > Thanks, > Ian.