All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
	stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com,
	dario.faggioli@citrix.com, ian.jackson@eu.citrix.com,
	xen-devel@lists.xen.org, jbeulich@suse.com, keir@xen.org,
	ufimtseva@gmail.com
Subject: Re: [PATCH v2 3/4] sysctl: Add sysctl interface for querying PCI topology
Date: Tue, 6 Jan 2015 16:55:10 +0000	[thread overview]
Message-ID: <20150106165510.GD28680@zion.uk.xensource.com> (raw)
In-Reply-To: <1420510737-22813-4-git-send-email-boris.ostrovsky@oracle.com>

On Mon, Jan 05, 2015 at 09:18:56PM -0500, Boris Ostrovsky wrote:
[...]
>  DEFINE_XEN_GUEST_HANDLE(xen_sysctl_lockprof_op_t);
>  
>  /* XEN_SYSCTL_cputopoinfo */

A bikeshed issue: is it better to just modified the above comment
instead of adding new trailing comment?

Wei.

> -#define INVALID_TOPOLOGY_ID  (~0U)
> +#define INVALID_TOPOLOGY_ID  (~0U) /* Also used by pcitopo */

  reply	other threads:[~2015-01-06 16:55 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06  2:18 [PATCH v2 0/4] Display IO topology when PXM data is available Boris Ostrovsky
2015-01-06  2:18 ` [PATCH v2 1/4] pci: Do not ignore device's PXM information Boris Ostrovsky
2015-01-06 11:55   ` Andrew Cooper
2015-01-07  9:01     ` Jan Beulich
2015-01-07  9:06   ` Jan Beulich
2015-01-07 14:42     ` Boris Ostrovsky
2015-01-07 14:47       ` Andrew Cooper
2015-01-07 15:07         ` Jan Beulich
2015-01-07 15:34           ` Boris Ostrovsky
2015-01-07 15:46             ` Jan Beulich
2015-01-07 15:06       ` Jan Beulich
2015-01-07 15:31         ` Boris Ostrovsky
2015-01-07 15:44           ` Jan Beulich
2015-01-06  2:18 ` [PATCH v2 2/4] sysctl: Make XEN_SYSCTL_topologyinfo sysctl a little more efficient Boris Ostrovsky
2015-01-06 13:41   ` Andrew Cooper
2015-01-06 14:45     ` Boris Ostrovsky
2015-01-07  9:12     ` Jan Beulich
2015-01-07 14:45       ` Boris Ostrovsky
2015-01-07 15:09         ` Jan Beulich
2015-01-16 15:56       ` Boris Ostrovsky
2015-01-16 16:06         ` Jan Beulich
2015-01-16 16:14           ` Boris Ostrovsky
2015-01-16 16:20             ` Jan Beulich
2015-01-16 16:34               ` Boris Ostrovsky
2015-01-16 16:42                 ` Jan Beulich
2015-01-16 16:16           ` Ian Campbell
2015-01-16 16:34             ` Jan Beulich
2015-01-16 16:38               ` Ian Campbell
2015-01-16 16:45                 ` Jan Beulich
2015-01-16 16:57                   ` Andrew Cooper
2015-01-16 17:07                     ` Boris Ostrovsky
2015-01-19  8:57                       ` Jan Beulich
2015-01-19 10:48                         ` Ian Campbell
2015-01-07 15:23     ` Jan Beulich
2015-01-19 17:26   ` Ian Campbell
2015-01-06  2:18 ` [PATCH v2 3/4] sysctl: Add sysctl interface for querying PCI topology Boris Ostrovsky
2015-01-06 16:55   ` Wei Liu [this message]
2015-01-06 18:15     ` Boris Ostrovsky
2015-01-07  9:21   ` Jan Beulich
2015-01-07 14:55     ` Boris Ostrovsky
2015-01-07 15:17       ` Jan Beulich
2015-01-07 15:54         ` Boris Ostrovsky
2015-01-07 16:52           ` Jan Beulich
2015-01-07 17:55           ` Dario Faggioli
2015-01-08  9:50             ` Jan Beulich
2015-01-08 15:49               ` Boris Ostrovsky
2015-01-08 15:54                 ` Jan Beulich
2015-01-06  2:18 ` [PATCH v2 4/4] libxl: Add interface for querying hypervisor about " Boris Ostrovsky
2015-01-06 17:08   ` Wei Liu
2015-01-07  9:04   ` Dario Faggioli
2015-01-07 14:15     ` Boris Ostrovsky
2015-01-07 14:45       ` Dario Faggioli
2015-01-19 17:32   ` Ian Campbell
2015-01-20 10:54     ` Roger Pau Monné
2015-01-20 10:56       ` Ian Campbell
2015-01-20 15:15     ` Boris Ostrovsky
2015-01-20 15:21       ` Ian Campbell
2015-01-20 16:04         ` Boris Ostrovsky
2015-01-20 16:15           ` Ian Campbell
2015-01-20 16:08     ` Egger, Christoph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150106165510.GD28680@zion.uk.xensource.com \
    --to=wei.liu2@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=dario.faggioli@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=ufimtseva@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.