From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8qqK-0000aJ-0f for qemu-devel@nongnu.org; Wed, 07 Jan 2015 08:40:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8qqF-0005gM-Tu for qemu-devel@nongnu.org; Wed, 07 Jan 2015 08:40:11 -0500 Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:64357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8qqF-0005ek-Nh for qemu-devel@nongnu.org; Wed, 07 Jan 2015 08:40:07 -0500 Received: by mail-wg0-f52.google.com with SMTP id x12so1193877wgg.11 for ; Wed, 07 Jan 2015 05:40:05 -0800 (PST) Date: Wed, 7 Jan 2015 13:15:45 +0000 From: Stefan Hajnoczi Message-ID: <20150107131545.GA22440@stefanha-thinkpad.redhat.com> References: <1420550957-22337-1-git-send-email-marcel@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY" Content-Disposition: inline In-Reply-To: <1420550957-22337-1-git-send-email-marcel@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: peter.maydell@linaro.org, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, lersek@redhat.com, afaerber@suse.de, rth@twiddle.net --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 06, 2015 at 03:29:11PM +0200, Marcel Apfelbaum wrote: > Patch e79d5a6 ("machine: remove qemu_machine_opts global list") removed o= ption > descriptions from the -machine QemuOptsList to avoid repeating MachineSta= te's QOM properties. >=20 > This resulted in a Qemu crash: > $ qemu-system-x86_64 -usb > qemu-system-x86_64: util/qemu-option.c:387: qemu_opt_get_bool_helper: > Assertion `opt->desc && opt->desc->type =3D=3D QEMU_OPT_BOOL' failed. > Aborted (core dumped) >=20 > Fixed it by simplifying usb_enabled usage: > - removed the usb_enabled argument > - call directly to machine's QOM property. > - expose defaults_enabled to calling sites >=20 > As part of this series the semantics for some ppc machines to > create the default usb controller were changed, but I still think > is correct, please let me know if you see a problem there. >=20 > Based on the comments I will receive, I will continue to fix the options > properties in the same way. >=20 > Marcel Apfelbaum (6): > hw/ppc: modified the condition for usb controllers to be created for > some ppc machines > hw/machine: added machine_usb wrapper > hw/usb: simplified usb_enabled > hw/ppc/mac_newworld: QOMified mac99 machines > hw/ppc/spapr: simplify usb controller creation logic > hw/ppc/mac_newworld: simplify usb controller creation logic >=20 > hw/arm/nseries.c | 2 +- > hw/arm/pxa2xx.c | 4 ++-- > hw/arm/realview.c | 2 +- > hw/arm/versatilepb.c | 2 +- > hw/core/machine.c | 5 +++++ > hw/i386/pc_piix.c | 2 +- > hw/i386/pc_q35.c | 2 +- > hw/ppc/mac_newworld.c | 32 +++++++++++++++++++++----------- > hw/ppc/mac_oldworld.c | 2 +- > hw/ppc/prep.c | 2 +- > hw/ppc/spapr.c | 3 ++- > include/hw/boards.h | 2 ++ > include/sysemu/sysemu.h | 3 ++- > vl.c | 16 ++++++++++------ > 14 files changed, 51 insertions(+), 28 deletions(-) >=20 > --=20 > 2.1.0 >=20 >=20 Reviewed-by: Stefan Hajnoczi --OXfL5xGRrasGEqWY Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUrTGBAAoJEJykq7OBq3PIT1MH/366ZEPFWo0S3RtICXp8XoXh 2o0UKrBtwY52/i+Zev7bjS6F377VWYehKNGvD7gbJnKEX8y50WSBZeR1KaS/hrRp r4SlP/qILYVLnnXExCkrLciKvpOHhQEj4NHLcl4rv0SAn/dXcNVNhhzTJI1ue0Jp 0pCmrrtmHkGt7QgdydG7zA0lTgcMB3fWeXyTqQKl8j7Hm20qWzuIztrMDSLVjZhI CeYAajVKqt24QPG7zTKuQ3VEjzPf7AV3PI+xcmZjNMT8hLjdMkThhdMxiw1OKjxD loTkPxUTBdoH+2EIQa1NFgMdx+ENeKCos9VHMOuaI1EelDXfLxsYeIIRK/Xizok= =HcAn -----END PGP SIGNATURE----- --OXfL5xGRrasGEqWY--