From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Wed, 07 Jan 2015 17:30:22 +0000 Subject: Re: linux-next: Tree for Jan 7 Message-Id: <20150107173022.GA26631@roeck-us.net> List-Id: References: <20150107151618.7cb9d574@canb.auug.org.au> <20150107142656.GA5666@roeck-us.net> <20150107163310.GZ5280@linux.vnet.ibm.com> In-Reply-To: <20150107163310.GZ5280@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Paul E. McKenney" Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Borntraeger , linux-sh@vger.kernel.org On Wed, Jan 07, 2015 at 08:33:10AM -0800, Paul E. McKenney wrote: > On Wed, Jan 07, 2015 at 06:26:56AM -0800, Guenter Roeck wrote: > > On Wed, Jan 07, 2015 at 03:16:18PM +1100, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since 20150106: > > > > > > *crickets* > > > > > > Non-merge commits (relative to Linus' tree): 1350 > > > 1543 files changed, 41856 insertions(+), 24250 deletions(-) > > > > > > ---------------------------------------------------------------------------- > > > > > > > New build failure for sh:dreamcast_defconfig: > > > > arch/sh/mm/gup.c: In function 'gup_get_pte': > > arch/sh/mm/gup.c:20:2: error: invalid initializer > > make[1]: *** [arch/sh/mm/gup.o] Error 1 > > > > bisect log: > > > > # bad: [7e3619a6de57f0257a2f6480182d2287ee05e314] Add linux-next specific files for 20150107 > > # good: [b1940cd21c0f4abdce101253e860feff547291b0] Linux 3.19-rc3 > > git bisect start 'HEAD' 'v3.19-rc3' > > # good: [c48667c5659248ff2b2fbff5cd23c43b5768e81b] Merge remote-tracking branch 'net-next/master' > > git bisect good c48667c5659248ff2b2fbff5cd23c43b5768e81b > > # good: [b8cf629ce7d554711dd7ab256b00e6110355e1d7] Merge remote-tracking branch 'mmc-uh/next' > > git bisect good b8cf629ce7d554711dd7ab256b00e6110355e1d7 > > # good: [cc52ff032bc2d91c78d7cf9aefcfa9e266ace816] Merge remote-tracking branch 'rcu/rcu/next' > > git bisect good cc52ff032bc2d91c78d7cf9aefcfa9e266ace816 > > # bad: [9634277bcdab7b9d6a91409dc11d85502aa2e74b] Merge remote-tracking branch 'access_once/linux-next' > > git bisect bad 9634277bcdab7b9d6a91409dc11d85502aa2e74b > > # good: [261379560ee6aa65b4869c94eda0d3d60773aca3] Merge remote-tracking branch 'scsi/for-next' > > git bisect good 261379560ee6aa65b4869c94eda0d3d60773aca3 > > # good: [38d45afa56bfca714780e45532760d64cd53b65b] Merge remote-tracking branch 'llvmlinux/for-next' > > git bisect good 38d45afa56bfca714780e45532760d64cd53b65b > > # good: [9afbe1ce2403c7d097bfaafcc5b27950040f7608] Merge remote-tracking branch 'y2038/y2038' > > git bisect good 9afbe1ce2403c7d097bfaafcc5b27950040f7608 > > # bad: [a91ed664749cbec0325ef9da7d12619d9bb72e2d] kernel: tighten rules for ACCESS ONCE > > git bisect bad a91ed664749cbec0325ef9da7d12619d9bb72e2d > > # good: [e3865cc4a17e979e6b2f26af026686fae5567096] x86/xen/p2m: Replace ACCESS_ONCE with READ_ONCE > > git bisect good e3865cc4a17e979e6b2f26af026686fae5567096 > > # good: [e2579c6f22ee0a43394d603cef6989dca98c5610] mm/gup: Replace ACCESS_ONCE with READ_ONCE > > git bisect good e2579c6f22ee0a43394d603cef6989dca98c5610 > > # first bad commit: [a91ed664749cbec0325ef9da7d12619d9bb72e2d] kernel: tighten rules for ACCESS ONCE > > > > Maybe the ACCESS_ONCE in the affected file should be replaced with READ_ONCE ? > > That is my belief. What happens when you try it? > Build passes, and my qemu tests pass as well. That doesn't mean that the change is correct, of course, since I don't know if the code in question is executed. Should I send a patch with the change ? Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754358AbbAGRbP (ORCPT ); Wed, 7 Jan 2015 12:31:15 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:53029 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754272AbbAGRbJ (ORCPT ); Wed, 7 Jan 2015 12:31:09 -0500 Date: Wed, 7 Jan 2015 09:30:22 -0800 From: Guenter Roeck To: "Paul E. McKenney" Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Borntraeger , linux-sh@vger.kernel.org Subject: Re: linux-next: Tree for Jan 7 Message-ID: <20150107173022.GA26631@roeck-us.net> References: <20150107151618.7cb9d574@canb.auug.org.au> <20150107142656.GA5666@roeck-us.net> <20150107163310.GZ5280@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150107163310.GZ5280@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020206.54AD6D6A.013C,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 4 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 07, 2015 at 08:33:10AM -0800, Paul E. McKenney wrote: > On Wed, Jan 07, 2015 at 06:26:56AM -0800, Guenter Roeck wrote: > > On Wed, Jan 07, 2015 at 03:16:18PM +1100, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since 20150106: > > > > > > *crickets* > > > > > > Non-merge commits (relative to Linus' tree): 1350 > > > 1543 files changed, 41856 insertions(+), 24250 deletions(-) > > > > > > ---------------------------------------------------------------------------- > > > > > > > New build failure for sh:dreamcast_defconfig: > > > > arch/sh/mm/gup.c: In function 'gup_get_pte': > > arch/sh/mm/gup.c:20:2: error: invalid initializer > > make[1]: *** [arch/sh/mm/gup.o] Error 1 > > > > bisect log: > > > > # bad: [7e3619a6de57f0257a2f6480182d2287ee05e314] Add linux-next specific files for 20150107 > > # good: [b1940cd21c0f4abdce101253e860feff547291b0] Linux 3.19-rc3 > > git bisect start 'HEAD' 'v3.19-rc3' > > # good: [c48667c5659248ff2b2fbff5cd23c43b5768e81b] Merge remote-tracking branch 'net-next/master' > > git bisect good c48667c5659248ff2b2fbff5cd23c43b5768e81b > > # good: [b8cf629ce7d554711dd7ab256b00e6110355e1d7] Merge remote-tracking branch 'mmc-uh/next' > > git bisect good b8cf629ce7d554711dd7ab256b00e6110355e1d7 > > # good: [cc52ff032bc2d91c78d7cf9aefcfa9e266ace816] Merge remote-tracking branch 'rcu/rcu/next' > > git bisect good cc52ff032bc2d91c78d7cf9aefcfa9e266ace816 > > # bad: [9634277bcdab7b9d6a91409dc11d85502aa2e74b] Merge remote-tracking branch 'access_once/linux-next' > > git bisect bad 9634277bcdab7b9d6a91409dc11d85502aa2e74b > > # good: [261379560ee6aa65b4869c94eda0d3d60773aca3] Merge remote-tracking branch 'scsi/for-next' > > git bisect good 261379560ee6aa65b4869c94eda0d3d60773aca3 > > # good: [38d45afa56bfca714780e45532760d64cd53b65b] Merge remote-tracking branch 'llvmlinux/for-next' > > git bisect good 38d45afa56bfca714780e45532760d64cd53b65b > > # good: [9afbe1ce2403c7d097bfaafcc5b27950040f7608] Merge remote-tracking branch 'y2038/y2038' > > git bisect good 9afbe1ce2403c7d097bfaafcc5b27950040f7608 > > # bad: [a91ed664749cbec0325ef9da7d12619d9bb72e2d] kernel: tighten rules for ACCESS ONCE > > git bisect bad a91ed664749cbec0325ef9da7d12619d9bb72e2d > > # good: [e3865cc4a17e979e6b2f26af026686fae5567096] x86/xen/p2m: Replace ACCESS_ONCE with READ_ONCE > > git bisect good e3865cc4a17e979e6b2f26af026686fae5567096 > > # good: [e2579c6f22ee0a43394d603cef6989dca98c5610] mm/gup: Replace ACCESS_ONCE with READ_ONCE > > git bisect good e2579c6f22ee0a43394d603cef6989dca98c5610 > > # first bad commit: [a91ed664749cbec0325ef9da7d12619d9bb72e2d] kernel: tighten rules for ACCESS ONCE > > > > Maybe the ACCESS_ONCE in the affected file should be replaced with READ_ONCE ? > > That is my belief. What happens when you try it? > Build passes, and my qemu tests pass as well. That doesn't mean that the change is correct, of course, since I don't know if the code in question is executed. Should I send a patch with the change ? Guenter