* [PATCH] clk: tegra: Fix order of arguments in WARN
@ 2014-09-30 7:22 Tomeu Vizoso
2015-01-09 11:39 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Tomeu Vizoso @ 2014-09-30 7:22 UTC (permalink / raw)
To: Peter De Schrijver
Cc: Prashant Gaikwad, Mike Turquette, Stephen Warren, Thierry Reding,
linux-kernel, linux-tegra, Tomeu Vizoso
As previously the names of the present clock and its parent were swapped.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
Hi,
I'm not a native English speaker, but the way the current message is made me
think that the clock that failed registration was the wrong one.
Regards,
Tomeu
---
drivers/clk/tegra/clk-pll.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
index c7c6d8f..fd18d2e 100644
--- a/drivers/clk/tegra/clk-pll.c
+++ b/drivers/clk/tegra/clk-pll.c
@@ -1565,7 +1565,7 @@ struct clk *tegra_clk_register_pllxc(const char *name, const char *parent_name,
parent = __clk_lookup(parent_name);
if (!parent) {
WARN(1, "parent clk %s of %s must be registered first\n",
- name, parent_name);
+ parent_name, name);
return ERR_PTR(-EINVAL);
}
@@ -1665,7 +1665,7 @@ struct clk *tegra_clk_register_pllm(const char *name, const char *parent_name,
parent = __clk_lookup(parent_name);
if (!parent) {
WARN(1, "parent clk %s of %s must be registered first\n",
- name, parent_name);
+ parent_name, name);
return ERR_PTR(-EINVAL);
}
@@ -1706,7 +1706,7 @@ struct clk *tegra_clk_register_pllc(const char *name, const char *parent_name,
parent = __clk_lookup(parent_name);
if (!parent) {
WARN(1, "parent clk %s of %s must be registered first\n",
- name, parent_name);
+ parent_name, name);
return ERR_PTR(-EINVAL);
}
@@ -1830,7 +1830,7 @@ struct clk *tegra_clk_register_pllss(const char *name, const char *parent_name,
parent = __clk_lookup(parent_name);
if (!parent) {
WARN(1, "parent clk %s of %s must be registered first\n",
- name, parent_name);
+ parent_name, name);
return ERR_PTR(-EINVAL);
}
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: tegra: Fix order of arguments in WARN
2014-09-30 7:22 [PATCH] clk: tegra: Fix order of arguments in WARN Tomeu Vizoso
@ 2015-01-09 11:39 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2015-01-09 11:39 UTC (permalink / raw)
To: Tomeu Vizoso
Cc: Peter De Schrijver, Prashant Gaikwad, Mike Turquette,
Stephen Warren, linux-kernel, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
On Tue, Sep 30, 2014 at 09:22:00AM +0200, Tomeu Vizoso wrote:
> As previously the names of the present clock and its parent were swapped.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-09 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-30 7:22 [PATCH] clk: tegra: Fix order of arguments in WARN Tomeu Vizoso
2015-01-09 11:39 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.