From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v3 5/8] gpio: Add Fujitsu MB86S7x GPIO driver Date: Fri, 9 Jan 2015 12:52:43 +0000 Message-ID: <20150109125243.GM12302@n2100.arm.linux.org.uk> References: <1420802369-3840-1-git-send-email-Vincent.Yang@tw.fujitsu.com> <1420803212-4350-1-git-send-email-Vincent.Yang@tw.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1420803212-4350-1-git-send-email-Vincent.Yang-l16TxrwUIHTQFUHtdCDX3A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vincent Yang Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, andy.green-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Vincent Yang , grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, jaswinder.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Tetsuya Nuriya List-Id: linux-gpio@vger.kernel.org On Fri, Jan 09, 2015 at 07:33:32PM +0800, Vincent Yang wrote: > +static int mb86s70_gpio_remove(struct platform_device *pdev) > +{ > + struct mb86s70_gpio_chip *gchip = platform_get_drvdata(pdev); > + > + gpiochip_remove(&gchip->gc); This doesn't disable and unprepare the clock. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Fri, 9 Jan 2015 12:52:43 +0000 Subject: [PATCH v3 5/8] gpio: Add Fujitsu MB86S7x GPIO driver In-Reply-To: <1420803212-4350-1-git-send-email-Vincent.Yang@tw.fujitsu.com> References: <1420802369-3840-1-git-send-email-Vincent.Yang@tw.fujitsu.com> <1420803212-4350-1-git-send-email-Vincent.Yang@tw.fujitsu.com> Message-ID: <20150109125243.GM12302@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jan 09, 2015 at 07:33:32PM +0800, Vincent Yang wrote: > +static int mb86s70_gpio_remove(struct platform_device *pdev) > +{ > + struct mb86s70_gpio_chip *gchip = platform_get_drvdata(pdev); > + > + gpiochip_remove(&gchip->gc); This doesn't disable and unprepare the clock. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.