From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752565AbbAJKpL (ORCPT ); Sat, 10 Jan 2015 05:45:11 -0500 Received: from mail-pd0-f171.google.com ([209.85.192.171]:49081 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbbAJKpI (ORCPT ); Sat, 10 Jan 2015 05:45:08 -0500 Date: Sat, 10 Jan 2015 19:44:58 +0900 From: Namhyung Kim To: Vineet Gupta Cc: "acme@redhat.com" , "peterz@infradead.org" , "jolsa@kernel.org" , "mingo@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-perf-users@vger.kernel.org" , "bp@suse.de" , "linux-arch@vger.kernel.org" , "Alexey.Brodkin@synopsys.com" Subject: Re: [PATCH 4/5] perf tools: [uclibc] don't rely on glibc malloc working for sz 0 Message-ID: <20150110104458.GC29697@danjae> References: <1420552335-26886-1-git-send-email-vgupta@synopsys.com> <1420552335-26886-5-git-send-email-vgupta@synopsys.com> <20150108075125.GF7268@sejong> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 10, 2015 at 10:16:06AM +0000, Vineet Gupta wrote: > On Thursday 08 January 2015 01:23 PM, Namhyung Kim wrote: > > Hmm.. okay. I think we don't need to allocate the id arrays when size > > is 0. So perf_event__process_attr() will have the same problem IMHO. > > How about this? > > > > > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > > index 1e90c8557ede..1d826d63bc20 100644 > > --- a/tools/perf/util/evsel.c > > +++ b/tools/perf/util/evsel.c > > @@ -797,6 +797,9 @@ int perf_evsel__enable(struct perf_evsel *evsel, int ncpus, int nthreads) > > > > int perf_evsel__alloc_id(struct perf_evsel *evsel, int ncpus, int nthreads) > > { > > + if (ncpus == 0 || nthreads == 0) > > + return 0; > > + > > if (evsel->system_wide) > > nthreads = 1; > > Fine by me as I'm not too familiar with perf tools internals. > So I need to spin a v2 for this or would you rather create a patch with me as > Reported-by: Please include this in your v2 and adds me as Suggested-by: Thanks, Namhyung