From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAdfr-00084D-Q1 for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:00:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAdfo-0006p5-BQ for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:00:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAdfo-0006ou-3N for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:00:44 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0CC0gVt016266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 12 Jan 2015 07:00:43 -0500 Date: Mon, 12 Jan 2015 17:30:39 +0530 From: Amit Shah Message-ID: <20150112120039.GK9688@grmbl.mre> References: <54B3A140.4090201@gmail.com> <20150112105501.GH9688@grmbl.mre> <54B3B524.1090601@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54B3B524.1090601@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/1] ich9: add disable_s3, disable_s4, s4_val properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: Paolo Bonzini , "Michael S. Tsirkin" , qemu list , Igor Mammedov On (Mon) 12 Jan 2015 [13:51:00], Marcel Apfelbaum wrote: > On 01/12/2015 12:55 PM, Amit Shah wrote: > >On (Mon) 12 Jan 2015 [12:26:08], Marcel Apfelbaum wrote: > >>On 12/16/2014 01:23 PM, Amit Shah wrote: > >>>PIIX4 has disable_s3 and disable_s4 properties to enable or disable PM > >>>functions. Add such properties to the ICH9 chipset as well for the Q35 > >>>machine type. > >>> > >>>S3 / S4 are not guaranteed to always work (needs work in the guest as > >>>well as QEMU for things to work properly), and disabling advertising of > >>>these features ensures guests don't go into zombie state if something > >>>isn't working right. > >>> > >>>The defaults are kept the same as in PIIX4: both S3 and S4 are enabled > >>>by default. > >>> > >>>These can be disabled via the cmdline: > >>> > >>> ... -global ICH9-LPC,disable_s3=1 -global ICH9-LPC,disable_s4=1 > >> ^^^ ^^^ > >>Should be -global ICH9-LPC.disable_s3=1 -global ICH9-LPC.disable_s4=1 > > > >Indeed, thanks. > > > >>Hi Amit, thanks for answering my prev question. > >>I have one more:) > >> > >>I didn't see how the properties are connected to the ACPI mechanism. > I finally found it, acpi_get_pm_info in hw/i386/acpi-build.c > access the object's properties for both pc/q35. > > [discussed off-list] > Last thing that is missing is: > - in ich9_pm_init we have acpi_pm1_cnt_init(&pm->acpi_regs, &pm->io, 2); > - while in piix4_pm_initfn we have acpi_pm1_cnt_init(&s->ar, &s->io, s->s4_val); > > So ich9_pm_init can override the actual object property value, better if we update it > accordingly. Thanks, v2 sent. Amit