Re: Accounting objects support in nft

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Mon, Jan 12, 2015 at 11:39:27AM +0000, Patrick McHardy wrote:
> On 12.01, ana@soleta.eu wrote:
> > From: Ana Rey Botello <ana@soleta.eu>
> > 
> > Hi,
> > 
> > With this patchset, we add accounting objects support to let us
> > manipulate extended accounting objects.
> > 
> > Example of use in nft:
> > 
> >  # nft add acct ip filter http-traffic
> >  # nft add acct ip filter https-traffic
> > 
> >  # nft add rule ip filter output tcp dport 80 acct http-traffic
> >  # nft add rule ip filter output tcp dport 443 acct https-traffic
> 
> I'm wondering whether we really should use a new keyword for this
> or do something similar to sets where we have named and anonymous
> variants.
> 
> An alternative would be:
> 
> nft add counter ip filter http-traffic
> nft filter output tcp dport 80 counter http-traffic
> 
> It is after all just a named counter, so it seems clearer to me to
> reuse the keyword.

I like this named counters idea.

So Ana, respin to include the changes in nft_counter instead.

Also rename all _acct to _counter instead.

Thanks.