From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752424AbbALR53 (ORCPT ); Mon, 12 Jan 2015 12:57:29 -0500 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:34875 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750782AbbALR51 (ORCPT ); Mon, 12 Jan 2015 12:57:27 -0500 Date: Mon, 12 Jan 2015 17:57:06 +0000 From: Russell King - ARM Linux To: Jean-Francois Moine Cc: Philipp Zabel , Andrew Jackson , Jyri Sarha , Mark Brown , Dave Airlie , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v9 1/4] drm/i2c: tda998x: Add DT support for audio Message-ID: <20150112175705.GN12302@n2100.arm.linux.org.uk> References: <20150109130725.GN12302@n2100.arm.linux.org.uk> <54AFDE8D.3000504@arm.com> <20150109145741.GP12302@n2100.arm.linux.org.uk> <20150109183857.53d701a4@armhf> <20150109200127.GD12302@n2100.arm.linux.org.uk> <1421054728.3081.28.camel@pengutronix.de> <20150112122527.GF12302@n2100.arm.linux.org.uk> <1421071197.3081.44.camel@pengutronix.de> <20150112140456.GI12302@n2100.arm.linux.org.uk> <20150112181341.4a53ea24@armhf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150112181341.4a53ea24@armhf> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 12, 2015 at 06:13:41PM +0100, Jean-Francois Moine wrote: > On Mon, 12 Jan 2015 14:04:56 +0000 > Russell King - ARM Linux wrote: > > On Mon, Jan 12, 2015 at 02:59:57PM +0100, Philipp Zabel wrote: > > > Note that of_graph_parse_endpoint interprets the port node's reg > > > property as port id. And the unit address part of the node name should > > > match the first address in the reg property. > > This is not the case in vexpress-v2p-ca15_a7.dts. Hmm... as the DT binding doc doesn't specify this restriction, and we have a DT file which violates what Philipp has said, I think we ought to document that reg vs unit node name does not need to match each other, thereby making that official. > > So that's not going to work very well... because the AP register is a > > bitmask. > > > > I guess we could specify a node unit and reg, which the code otherwise > > ignores, and specify a philipps,ap-mask = property for the audio ports > > instead. > > Also, the video and audio ports must be distinguished. They could be > defined in different port groups. > > Example from the Cubox: > > video-ports: ports@0 { > port { > tda998x_video: endpoint { > remote-endpoint = <&lcd0_0>; > nxp,video-port = <0x230145>; > }; > }; > }; > audio-ports: ports@1 { > port@0 { /* AP1 = I2S */ > tda998x_i2s: endpoint@0 { > remote-endpoint = <&audio1_i2s>; > nxp,audio-port = <0x03>; > }; > }; > port@1 { /* AP2 = S/PDIF */ > tda998x_spdif: endpoint@1 { > remote-endpoint = <&audio1_spdif1>; > nxp,audio-port = <0x04>; > }; > }; > }; > > The port type is identified by the bit AP0. I don't particularly like that - that makes the assumption that AP0 always means I2S. What if a future chip decides to allow SPDIF on AP0? Why should we need to re-invent the binding? IMHO, it would be much better to make this explicit. Note that the "video-ports" and "audio-ports" are just labels in the DT file; they aren't carried through to the resulting DT binary file, so they don't have any meaning to the kernel. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v9 1/4] drm/i2c: tda998x: Add DT support for audio Date: Mon, 12 Jan 2015 17:57:06 +0000 Message-ID: <20150112175705.GN12302@n2100.arm.linux.org.uk> References: <20150109130725.GN12302@n2100.arm.linux.org.uk> <54AFDE8D.3000504@arm.com> <20150109145741.GP12302@n2100.arm.linux.org.uk> <20150109183857.53d701a4@armhf> <20150109200127.GD12302@n2100.arm.linux.org.uk> <1421054728.3081.28.camel@pengutronix.de> <20150112122527.GF12302@n2100.arm.linux.org.uk> <1421071197.3081.44.camel@pengutronix.de> <20150112140456.GI12302@n2100.arm.linux.org.uk> <20150112181341.4a53ea24@armhf> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20150112181341.4a53ea24@armhf> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jean-Francois Moine Cc: "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , Andrew Jackson , "linux-kernel@vger.kernel.org" , Jyri Sarha , Mark Brown , "dri-devel@lists.freedesktop.org" List-Id: devicetree@vger.kernel.org T24gTW9uLCBKYW4gMTIsIDIwMTUgYXQgMDY6MTM6NDFQTSArMDEwMCwgSmVhbi1GcmFuY29pcyBN b2luZSB3cm90ZToKPiBPbiBNb24sIDEyIEphbiAyMDE1IDE0OjA0OjU2ICswMDAwCj4gUnVzc2Vs bCBLaW5nIC0gQVJNIExpbnV4IDxsaW51eEBhcm0ubGludXgub3JnLnVrPiB3cm90ZToKPiA+IE9u IE1vbiwgSmFuIDEyLCAyMDE1IGF0IDAyOjU5OjU3UE0gKzAxMDAsIFBoaWxpcHAgWmFiZWwgd3Jv dGU6Cj4gPiA+IE5vdGUgdGhhdCBvZl9ncmFwaF9wYXJzZV9lbmRwb2ludCBpbnRlcnByZXRzIHRo ZSBwb3J0IG5vZGUncyByZWcKPiA+ID4gcHJvcGVydHkgYXMgcG9ydCBpZC4gQW5kIHRoZSB1bml0 IGFkZHJlc3MgcGFydCBvZiB0aGUgbm9kZSBuYW1lIHNob3VsZAo+ID4gPiBtYXRjaCB0aGUgZmly c3QgYWRkcmVzcyBpbiB0aGUgcmVnIHByb3BlcnR5Lgo+IAo+IFRoaXMgaXMgbm90IHRoZSBjYXNl IGluIHZleHByZXNzLXYycC1jYTE1X2E3LmR0cy4KCkhtbS4uLiBhcyB0aGUgRFQgYmluZGluZyBk b2MgZG9lc24ndCBzcGVjaWZ5IHRoaXMgcmVzdHJpY3Rpb24sIGFuZCB3ZQpoYXZlIGEgRFQgZmls ZSB3aGljaCB2aW9sYXRlcyB3aGF0IFBoaWxpcHAgaGFzIHNhaWQsIEkgdGhpbmsgd2Ugb3VnaHQK dG8gZG9jdW1lbnQgdGhhdCByZWcgdnMgdW5pdCBub2RlIG5hbWUgZG9lcyBub3QgbmVlZCB0byBt YXRjaCBlYWNoCm90aGVyLCB0aGVyZWJ5IG1ha2luZyB0aGF0IG9mZmljaWFsLgoKPiA+IFNvIHRo YXQncyBub3QgZ29pbmcgdG8gd29yayB2ZXJ5IHdlbGwuLi4gYmVjYXVzZSB0aGUgQVAgcmVnaXN0 ZXIgaXMgYQo+ID4gYml0bWFzay4KPiA+IAo+ID4gSSBndWVzcyB3ZSBjb3VsZCBzcGVjaWZ5IGEg bm9kZSB1bml0IGFuZCByZWcsIHdoaWNoIHRoZSBjb2RlIG90aGVyd2lzZQo+ID4gaWdub3Jlcywg YW5kIHNwZWNpZnkgYSBwaGlsaXBwcyxhcC1tYXNrID0gcHJvcGVydHkgZm9yIHRoZSBhdWRpbyBw b3J0cwo+ID4gaW5zdGVhZC4KPiAKPiBBbHNvLCB0aGUgdmlkZW8gYW5kIGF1ZGlvIHBvcnRzIG11 c3QgYmUgZGlzdGluZ3Vpc2hlZC4gVGhleSBjb3VsZCBiZQo+IGRlZmluZWQgaW4gZGlmZmVyZW50 IHBvcnQgZ3JvdXBzLgo+IAo+IEV4YW1wbGUgZnJvbSB0aGUgQ3Vib3g6Cj4gCj4gCXZpZGVvLXBv cnRzOiBwb3J0c0AwIHsKPiAJCXBvcnQgewo+IAkJCXRkYTk5OHhfdmlkZW86IGVuZHBvaW50IHsK PiAJCQkJcmVtb3RlLWVuZHBvaW50ID0gPCZsY2QwXzA+Owo+IAkJCQlueHAsdmlkZW8tcG9ydCA9 IDwweDIzMDE0NT47Cj4gCQkJfTsKPiAJCX07Cj4gCX07Cj4gCWF1ZGlvLXBvcnRzOiBwb3J0c0Ax IHsKPiAJCXBvcnRAMCB7CQkJLyogQVAxID0gSTJTICovCj4gCQkJdGRhOTk4eF9pMnM6IGVuZHBv aW50QDAgewo+IAkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JmF1ZGlvMV9pMnM+Owo+IAkJCQlueHAs YXVkaW8tcG9ydCA9IDwweDAzPjsKPiAJCQl9Owo+IAkJfTsKPiAJCXBvcnRAMSB7CQkJIC8qIEFQ MiA9IFMvUERJRiAqLwo+IAkJCXRkYTk5OHhfc3BkaWY6IGVuZHBvaW50QDEgewo+IAkJCQlyZW1v dGUtZW5kcG9pbnQgPSA8JmF1ZGlvMV9zcGRpZjE+Owo+IAkJCQlueHAsYXVkaW8tcG9ydCA9IDww eDA0PjsKPiAJCQl9Owo+IAkJfTsKPiAJfTsKPiAKPiBUaGUgcG9ydCB0eXBlIGlzIGlkZW50aWZp ZWQgYnkgdGhlIGJpdCBBUDAuCgpJIGRvbid0IHBhcnRpY3VsYXJseSBsaWtlIHRoYXQgLSB0aGF0 IG1ha2VzIHRoZSBhc3N1bXB0aW9uIHRoYXQgQVAwCmFsd2F5cyBtZWFucyBJMlMuICBXaGF0IGlm IGEgZnV0dXJlIGNoaXAgZGVjaWRlcyB0byBhbGxvdyBTUERJRiBvbgpBUDA/ICBXaHkgc2hvdWxk IHdlIG5lZWQgdG8gcmUtaW52ZW50IHRoZSBiaW5kaW5nPwoKSU1ITywgaXQgd291bGQgYmUgbXVj aCBiZXR0ZXIgdG8gbWFrZSB0aGlzIGV4cGxpY2l0LgoKTm90ZSB0aGF0IHRoZSAidmlkZW8tcG9y dHMiIGFuZCAiYXVkaW8tcG9ydHMiIGFyZSBqdXN0IGxhYmVscyBpbiB0aGUKRFQgZmlsZTsgdGhl eSBhcmVuJ3QgY2FycmllZCB0aHJvdWdoIHRvIHRoZSByZXN1bHRpbmcgRFQgYmluYXJ5IGZpbGUs CnNvIHRoZXkgZG9uJ3QgaGF2ZSBhbnkgbWVhbmluZyB0byB0aGUga2VybmVsLgoKLS0gCkZUVEMg YnJvYWRiYW5kIGZvciAwLjhtaWxlIGxpbmU6IGN1cnJlbnRseSBhdCAxMC41TWJwcyBkb3duIDQw MGticHMgdXAKYWNjb3JkaW5nIHRvIHNwZWVkdGVzdC5uZXQuCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==