All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sam van Kampen <sam@tehsvk.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Chris Bajumpaa <cbajumpa@gmail.com>,
	Monam Agarwal <monamagarwal123@gmail.com>,
	Davide Berardi <berardi.dav@gmail.com>,
	devel@driverdev.osuosl.org
Subject: Re: [PATCH] Staging: line6: fix parentheses around macro in usbdefs.h
Date: Mon, 12 Jan 2015 11:51:12 -0800	[thread overview]
Message-ID: <20150112195111.GA10572@kroah.com> (raw)
In-Reply-To: <20141203183442.GA3480@nsa.gov>

On Wed, Dec 03, 2014 at 07:34:42PM +0100, Sam van Kampen wrote:
> This patch fixes the error "Macros with complex values should be enclosed in
> parentheses", as reported by checkpatch.pl.
> 
> Signed-off-by: Sam van Kampen <sam@tehsvk.net>
> ---
>  drivers/staging/line6/usbdefs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/line6/usbdefs.h b/drivers/staging/line6/usbdefs.h
> index 2d1cc47..48958b5 100644
> --- a/drivers/staging/line6/usbdefs.h
> +++ b/drivers/staging/line6/usbdefs.h
> @@ -40,7 +40,7 @@
>  #define LINE6_DEVID_TONEPORT_UX2  0x4142
>  #define LINE6_DEVID_VARIAX        0x534d
>  
> -#define LINE6_BIT(x) LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x
> +#define LINE6_BIT(x) (LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x)
>  
>  enum {
>  	LINE6_INDEX_BASSPODXT,

I love this line in the driver, it proves that people make changes to
the code without even building it.

Please ALWAYS test-build your patches, otherwise you waste people's time
and make them grumpy.

greg k-h

  parent reply	other threads:[~2015-01-12 19:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03 18:34 [PATCH] Staging: line6: fix parentheses around macro in usbdefs.h Sam van Kampen
2014-12-03 18:45 ` Joe Perches
2015-01-12 19:51 ` Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-12-03  8:22 Sam van Kampen
2014-12-03 16:04 ` Greg Kroah-Hartman
2014-12-03 17:57   ` Sam van Kampen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150112195111.GA10572@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=berardi.dav@gmail.com \
    --cc=cbajumpa@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monamagarwal123@gmail.com \
    --cc=sam@tehsvk.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.