From: Alessandro Zummo <a.zummo@towertech.it>
To: Xunlei Pang <xlpang@126.com>
Cc: linux-kernel@vger.kernel.org,
John Stultz <john.stultz@linaro.org>,
Arnd Bergmann <arnd.bergmann@linaro.org>,
rtc-linux@googlegroups.com, Thomas Gleixner <tglx@linutronix.de>,
Xunlei Pang <pang.xunlei@linaro.org>
Subject: Re: [RFC PATCH v2 1/9] rtc: Provide y2038 safe rtc_class_ops.set_mmss() replacement
Date: Tue, 13 Jan 2015 17:12:46 +0100 [thread overview]
Message-ID: <20150113171246.76931f81@linux.lan.towertech.it> (raw)
In-Reply-To: <1421163897-8020-2-git-send-email-xlpang@126.com>
On Tue, 13 Jan 2015 23:44:49 +0800
Xunlei Pang <xlpang@126.com> wrote:
> + else if (rtc->ops->set_mmss64) {
> + ;
> +
> + secs64 = rtc_tm_to_time64(tm);
time64_t secs64 = rtc_tm_to_time64(tm);
would do as well. add spaces, variables
and empty lines only when required for readability.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2015-01-13 16:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 15:44 [RFC PATCH v2 0/9] Provide y2038/y2106 safe rtc_class_ops.set_mmss64() Xunlei Pang
2015-01-13 15:44 ` [RFC PATCH v2 1/9] rtc: Provide y2038 safe rtc_class_ops.set_mmss() replacement Xunlei Pang
2015-01-13 16:12 ` Alessandro Zummo [this message]
2015-01-13 15:44 ` [RFC PATCH v2 2/9] time: Provide y2106 safe get_seconds() replacement Xunlei Pang
2015-01-13 16:17 ` Alessandro Zummo
2015-01-13 20:34 ` Arnd Bergmann
2015-01-13 20:42 ` Thomas Gleixner
2015-01-14 14:52 ` Xunlei Pang
2015-01-13 15:44 ` [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues Xunlei Pang
2015-01-13 16:19 ` Alessandro Zummo
2015-01-14 14:56 ` Xunlei Pang
2015-01-14 15:03 ` Alessandro Zummo
2015-01-14 15:26 ` Xunlei Pang
2015-01-14 15:39 ` Alessandro Zummo
2015-01-16 15:40 ` Xunlei Pang
2015-01-13 15:44 ` [RFC PATCH v2 4/9] rtc/ab3100: " Xunlei Pang
2015-01-13 16:20 ` Alessandro Zummo
2015-01-15 17:23 ` Linus Walleij
2015-01-13 15:44 ` [RFC PATCH v2 5/9] rtc/mc13xxx: " Xunlei Pang
2015-01-14 15:07 ` Xunlei Pang
2015-01-14 17:03 ` Uwe Kleine-König
2015-01-13 15:44 ` [RFC PATCH v2 6/9] rtc/mxc: Modify rtc_update_alarm() not to touch the alarm time Xunlei Pang
2015-01-13 16:23 ` Alessandro Zummo
2015-01-14 15:13 ` Xunlei Pang
2015-01-13 15:44 ` [RFC PATCH v2 7/9] rtc/mxc: Convert get_alarm_or_time()/set_alarm_or_time() to use time64_t Xunlei Pang
2015-01-13 15:44 ` [RFC PATCH v2 8/9] rtc/mxc: Update driver to address y2038/y2106 issues Xunlei Pang
2015-01-13 15:44 ` [RFC PATCH v2 9/9] alpha: change to use rtc_class_ops's set_mmss64() Xunlei Pang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150113171246.76931f81@linux.lan.towertech.it \
--to=a.zummo@towertech.it \
--cc=arnd.bergmann@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pang.xunlei@linaro.org \
--cc=rtc-linux@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=xlpang@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.